Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/common/extensions/manifest.cc

Issue 22938005: Add ErrorConsole UI for Extension Install Warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_install_warnings
Patch Set: More robust highlighting + testing Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest.cc
diff --git a/chrome/common/extensions/manifest.cc b/chrome/common/extensions/manifest.cc
index 15d62e5a69a3f2deba4edb7fbeba7d3055da4eeb..d8dbb87ebfd961e056168af3fb77a49af751373c 100644
--- a/chrome/common/extensions/manifest.cc
+++ b/chrome/common/extensions/manifest.cc
@@ -10,6 +10,7 @@
#include "base/strings/string_split.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
+#include "chrome/common/extensions/extension_manifest_constants.h"
#include "chrome/common/extensions/features/feature.h"
#include "extensions/common/error_utils.h"
#include "extensions/common/features/feature_provider.h"
@@ -160,8 +161,8 @@ bool Manifest::ValidateManifest(
it.Advance()) {
if (!provider->GetFeature(it.key())) {
warnings->push_back(InstallWarning(
- base::StringPrintf("Unrecognized manifest key '%s'.",
- it.key().c_str()),
+ ErrorUtils::FormatErrorMessage(
+ extension_manifest_errors::kUnrecognizedManifestKey, it.key()),
it.key()));
}
}

Powered by Google App Engine
This is Rietveld 408576698