Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3530)

Unified Diff: chrome/common/extensions/permissions/permissions_data.cc

Issue 22938005: Add ErrorConsole UI for Extension Install Warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_install_warnings
Patch Set: More robust highlighting + testing Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permissions_data.cc
diff --git a/chrome/common/extensions/permissions/permissions_data.cc b/chrome/common/extensions/permissions/permissions_data.cc
index a471f22784a9845209eaa9b291605a0a3214a8e3..83bb588fc3c33c74cfb6b398a930b892b8b96595 100644
--- a/chrome/common/extensions/permissions/permissions_data.cc
+++ b/chrome/common/extensions/permissions/permissions_data.cc
@@ -231,9 +231,9 @@ bool ParseHelper(Extension* extension,
// It's probably an unknown API permission. Do not throw an error so
// extensions can retain backwards compatability (http://crbug.com/42742).
extension->AddInstallWarning(InstallWarning(
- base::StringPrintf(
- "Permission '%s' is unknown or URL pattern is malformed.",
- permission_str.c_str()),
+ ErrorUtils::FormatErrorMessage(
+ errors::kPermissionUnknownOrMalformed,
+ permission_str),
key,
permission_str));
}

Powered by Google App Engine
This is Rietveld 408576698