Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2293743002:
Remove ContainerViewObserver (Closed)
|
Created:
4 years, 3 months ago by Jinsuk Kim Modified:
4 years, 3 months ago CC:
chromium-reviews, posciak+watch_chromium.org, jam, darin-cc_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove ContainerViewObserver
ContainerViewObserver is used by ExternalVideoSurfaceContainer
only, which in turn used by Chromecast/WebView.
Since Chromecast never updates container view in its lifecycle,
it can go without using ContainerViewObserver. And WebView
disabled support for video hole since M52.
With that, ContainerViewObserver is not used any more. This CL
deletes the class.
BUG=624977
Committed: https://crrev.com/03c7e50720e3a9e79cc2b443269b8327bbe52475
Cr-Commit-Position: refs/heads/master@{#419403}
Patch Set 1 #
Messages
Total messages: 25 (15 generated)
Description was changed from ========== Remove ContainerViewObserver Since Chromecast never updates container view in its lifecycle, it can go without using ContainerViewObserver. With that, ContainerViewObserver is not used any more. This CL deletes the class. BUG=624977 ========== to ========== Remove ContainerViewObserver ContainerViewObserver is used by ExternalVideoSurfaceContainer only, which in turn used by Chromecast/WebView. Since Chromecast never updates container view in its lifecycle, it can go without using ContainerViewObserver. And WebView disabled support for video hole since M52. With that, ContainerViewObserver is not used any more. This CL deletes the class. BUG=624977 ==========
The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jinsukkim@chromium.org changed reviewers: + boliu@chromium.org, sievers@chromium.org
can we remove external_video_surface from webview first before landing this? +tima who was going to do that, but someone else can get to it first..
On 2016/08/31 17:41:42, boliu wrote: > can we remove external_video_surface from webview first before landing this? > > +tima who was going to do that, but someone else can get to it first.. preparing the CL to remove external_video_surface
On 2016/08/31 18:59:39, Tima Vaisburd wrote: > On 2016/08/31 17:41:42, boliu wrote: > > can we remove external_video_surface from webview first before landing this? > > > > +tima who was going to do that, but someone else can get to it first.. > > preparing the CL to remove external_video_surface Sorry, I promised to make a CL but got distracted. Please wait a little more...
The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/02 07:11:34, Tima Vaisburd wrote: > On 2016/08/31 18:59:39, Tima Vaisburd wrote: > > On 2016/08/31 17:41:42, boliu wrote: > > > can we remove external_video_surface from webview first before landing this? > > > > > > +tima who was going to do that, but someone else can get to it first.. > > > > preparing the CL to remove external_video_surface > > Sorry, I promised to make a CL but got distracted. Please wait a little more... Saw the CL land. Thanks! Can we resume reviewing now?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/09/07 22:56:28, Jinsuk wrote: > On 2016/09/02 07:11:34, Tima Vaisburd wrote: > > On 2016/08/31 18:59:39, Tima Vaisburd wrote: > > > On 2016/08/31 17:41:42, boliu wrote: > > > > can we remove external_video_surface from webview first before landing > this? > > > > > > > > +tima who was going to do that, but someone else can get to it first.. > > > > > > preparing the CL to remove external_video_surface > > > > Sorry, I promised to make a CL but got distracted. Please wait a little > more... > > Saw the CL land. Thanks! > Can we resume reviewing now? umm, in theory, should move component/external_video_surface to chromecast first, but that's probably a lot of work, meh.. lgtm
The CQ bit was checked by jinsukkim@chromium.org
The CQ bit was unchecked by jinsukkim@chromium.org
lgtm
The CQ bit was checked by jinsukkim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove ContainerViewObserver ContainerViewObserver is used by ExternalVideoSurfaceContainer only, which in turn used by Chromecast/WebView. Since Chromecast never updates container view in its lifecycle, it can go without using ContainerViewObserver. And WebView disabled support for video hole since M52. With that, ContainerViewObserver is not used any more. This CL deletes the class. BUG=624977 ========== to ========== Remove ContainerViewObserver ContainerViewObserver is used by ExternalVideoSurfaceContainer only, which in turn used by Chromecast/WebView. Since Chromecast never updates container view in its lifecycle, it can go without using ContainerViewObserver. And WebView disabled support for video hole since M52. With that, ContainerViewObserver is not used any more. This CL deletes the class. BUG=624977 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove ContainerViewObserver ContainerViewObserver is used by ExternalVideoSurfaceContainer only, which in turn used by Chromecast/WebView. Since Chromecast never updates container view in its lifecycle, it can go without using ContainerViewObserver. And WebView disabled support for video hole since M52. With that, ContainerViewObserver is not used any more. This CL deletes the class. BUG=624977 ========== to ========== Remove ContainerViewObserver ContainerViewObserver is used by ExternalVideoSurfaceContainer only, which in turn used by Chromecast/WebView. Since Chromecast never updates container view in its lifecycle, it can go without using ContainerViewObserver. And WebView disabled support for video hole since M52. With that, ContainerViewObserver is not used any more. This CL deletes the class. BUG=624977 Committed: https://crrev.com/03c7e50720e3a9e79cc2b443269b8327bbe52475 Cr-Commit-Position: refs/heads/master@{#419403} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/03c7e50720e3a9e79cc2b443269b8327bbe52475 Cr-Commit-Position: refs/heads/master@{#419403} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
