Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2293743002: Remove ContainerViewObserver (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index f7f3ccedb74ef11394aca7df48d17a9b69874e5d..84cf879a828b61dd3853d716b9307712cbe7e96d 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -429,7 +429,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen
private int mPotentiallyActiveFlingCount;
private SmartClipDataListener mSmartClipDataListener = null;
- private final ObserverList<ContainerViewObserver> mContainerViewObservers;
/**
* PID used to indicate an invalid render process.
@@ -498,7 +497,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen
mGestureStateListeners = new ObserverList<GestureStateListener>();
mGestureStateListenersIterator = mGestureStateListeners.rewindableIterator();
- mContainerViewObservers = new ObserverList<ContainerViewObserver>();
mWindowAndroidChangedObservers = new ObserverList<WindowAndroidChangedObserver>();
}
@@ -716,22 +714,11 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen
mContainerView = containerView;
mContainerView.setClickable(true);
- for (ContainerViewObserver observer : mContainerViewObservers) {
- observer.onContainerViewChanged(mContainerView);
- }
} finally {
TraceEvent.end("ContentViewCore.setContainerView");
}
}
- public void addContainerViewObserver(ContainerViewObserver observer) {
- mContainerViewObservers.addObserver(observer);
- }
-
- public void removeContainerViewObserver(ContainerViewObserver observer) {
- mContainerViewObservers.removeObserver(observer);
- }
-
@CalledByNative
private void onNativeContentViewCoreDestroyed(long nativeContentViewCore) {
assert nativeContentViewCore == mNativeContentViewCore;
@@ -847,7 +834,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen
}
mGestureStateListeners.clear();
ScreenOrientationListener.getInstance().removeObserver(this);
- mContainerViewObservers.clear();
hidePopupsAndPreserveSelection();
mPastePopupMenu = null;
« no previous file with comments | « components/external_video_surface/android/java/src/org/chromium/components/external_video_surface/ExternalVideoSurfaceContainer.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698