Source/bindings/tests/idls/TestInterfaceConstructor2.idl - Issue 229373006: Support optional, non-defaulted constructor arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/idls/TestInterfaceConstructor2.idl

Issue 229373006: Support optional, non-defaulted constructor arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code adjustments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/methods.cpp ('K') | « Source/bindings/templates/methods.cpp ('k') | Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/idls/TestInterfaceConstructor2.idl

diff --git a/Source/bindings/tests/idls/TestInterfaceConstructor2.idl b/Source/bindings/tests/idls/TestInterfaceConstructor2.idl

index d42461e8dfa83edb872f057d7a3455b60a92ce4a..67e6e0d74de352573b6dd8a0de3ddcd49023fb9c 100644

--- a/Source/bindings/tests/idls/TestInterfaceConstructor2.idl

+++ b/Source/bindings/tests/idls/TestInterfaceConstructor2.idl

@@ -42,7 +42,7 @@

TestInterfaceEmpty testInterfaceEmptyArg,

long longArg,

[Default=Undefined] optional DOMString defaultUndefinedOptionalStringArg,

- [Default=NullString] optional DOMString defaultNullStringOptionalStringArg,

- [Default=Undefined] optional Dictionary defaultUndefinedOptionalDictionaryArg),

+ [Default=Undefined] optional Dictionary defaultUndefinedOptionalDictionaryArg,

Nils Barth (inactive) 2014/04/10 01:01:23 ? Could you keep the [Default=NullString] argument

sof 2014/04/10 06:16:40 Done.

+ optional DOMString optionalStringArg),

] interface TestInterfaceConstructor2 {

};

« Source/bindings/templates/methods.cpp ('K') | « Source/bindings/templates/methods.cpp ('k') | Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl » ('j') | no next file with comments »