Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 229373002: Revert of [Android] Provide unhandled tap event notifications (Closed)

Created:
6 years, 8 months ago by tapted
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Ben Goodger (Google)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of [Android] Provide unhandled tap event notifications (https://codereview.chromium.org/218633008/) Reason for revert: TouchEditableImplAuraTest.TouchCursorInTextfieldTest failing in the waterfall on Linux ChromiumOS Tests (2) link: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22962 Original issue's description: > [Android] Reland "Provide unhandled tap event notifications" > > Allow notifications of unhandled taps via the GestureStateListener. This change > makes GestureTap events blocking, but there are several use-cases for which this > will be necessary, e.g., WebView and contextual search. > > This was landed in r26143 and reverted in r261470 due to to a failure in > TouchEditableImplAuraTest.TouchCursorInTextfieldTest. The test has been fixed. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262497 TBR=mkosiba@chromium.org,donnd@chromium.org,tedchoc@chromium.org,tdresser@chromium.org,sky@chromium.org,jdduke@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -41 lines) Patch
M content/browser/android/content_view_core_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 2 chunks +3 lines, -11 lines 0 comments Download
M content/common/input/web_input_event_traits.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +0 lines, -9 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/GestureStateListener.java View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of [Android] Provide unhandled tap event notifications
6 years, 8 months ago (2014-04-08 21:58:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/229373002/1
6 years, 8 months ago (2014-04-08 22:00:43 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 22:02:23 UTC) #3
Message was sent while issue was closed.
Change committed as 262517

Powered by Google App Engine
This is Rietveld 408576698