content/browser/web_contents/touch_editable_impl_aura_browsertest.cc - Issue 229373002: Revert of [Android] Provide unhandled tap event notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

Issue 229373002: Revert of [Android] Provide unhandled tap event notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/input_router_impl_unittest.cc ('k') | content/common/input/web_input_event_traits.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

diff --git a/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc b/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

index b4094b310a010db9b86e9530fa6edab93b59b18b..2a42dda5ccab1e2b6aab75e92cd4fafcf162063f 100644

--- a/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

+++ b/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

@@ -11,7 +11,6 @@

#include "base/values.h"

#include "content/browser/web_contents/web_contents_impl.h"

#include "content/browser/web_contents/web_contents_view_aura.h"

-#include "content/common/input/web_input_event_traits.h"

#include "content/public/browser/render_frame_host.h"

#include "content/public/browser/web_contents_view.h"

#include "content/public/common/content_switches.h"

@@ -325,16 +324,9 @@

// Tap textfield

touch_editable->Reset();

generator.GestureTapAt(gfx::Point(bounds.x() + 50, bounds.y() + 40));

- // Only wait for the tap gesture ack if it's received asynchronously.

- if (WebInputEventTraits::IgnoresAckDisposition(

- blink::WebInputEvent::GestureTap)) {

- touch_editable->WaitForSelectionChangeCallback();

- touch_editable->Reset();

- } else {

- touch_editable->Reset();

- touch_editable->WaitForGestureAck();

- touch_editable->WaitForSelectionChangeCallback();

- }

+ // Tap Down and Tap acks are sent synchronously.

+ touch_editable->WaitForSelectionChangeCallback();

+ touch_editable->Reset();

// Check if cursor handle is showing.

ui::TouchSelectionController* controller =