Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2293673002: [Feedback] Update strings per UX recommendations. (Closed)

Created:
4 years, 3 months ago by apacible
Modified:
4 years, 3 months ago
Reviewers:
afakhry, ainslie
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, apacible+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Feedback] Update strings per UX recommendations. Changes include: - Omitting trailing period and colons from labels/headers. - Omitting "optional" text from labels and adding group subheading to indicate optional fields. - Shorten some strings. Used camelCase for new string per presubmit guidelines for i18n-content. BUG=640604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/35eabf5bbca04507bfe6ae32b6f9e9d5cc251864 Cr-Commit-Position: refs/heads/master@{#415666}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M chrome/app/generated_resources.grd View 4 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/feedback/css/feedback.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/feedback/html/default.html View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
apacible
PTAL, thanks! Before: https://screenshot.googleplex.com/Z4YMEOhbDVf.png After: https://screenshot.googleplex.com/FPzUubwd2og.png
4 years, 3 months ago (2016-08-29 20:53:09 UTC) #6
afakhry
lgtm. Thank you for this clean up!
4 years, 3 months ago (2016-08-29 21:09:06 UTC) #8
apacible
ainslie@: friendly ping for UX review :)
4 years, 3 months ago (2016-08-31 01:13:56 UTC) #12
ainslie
(for LR UI-bit flipping, let me know when to look at the implementation in canary. ...
4 years, 3 months ago (2016-08-31 03:04:05 UTC) #13
apacible
On 2016/08/31 03:04:05, ainslie wrote: > (for LR UI-bit flipping, let me know when to ...
4 years, 3 months ago (2016-08-31 03:15:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293673002/1
4 years, 3 months ago (2016-08-31 03:16:08 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/121463)
4 years, 3 months ago (2016-08-31 03:34:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293673002/1
4 years, 3 months ago (2016-08-31 16:35:08 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 17:15:05 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 17:18:44 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35eabf5bbca04507bfe6ae32b6f9e9d5cc251864
Cr-Commit-Position: refs/heads/master@{#415666}

Powered by Google App Engine
This is Rietveld 408576698