Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 2293673002: [Feedback] Update strings per UX recommendations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/feedback/css/feedback.css » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/feedback_private/feedback_private_api.h" 5 #include "chrome/browser/extensions/api/feedback_private/feedback_private_api.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 147
148 // static 148 // static
149 base::Closure* FeedbackPrivateGetStringsFunction::test_callback_ = NULL; 149 base::Closure* FeedbackPrivateGetStringsFunction::test_callback_ = NULL;
150 150
151 bool FeedbackPrivateGetStringsFunction::RunSync() { 151 bool FeedbackPrivateGetStringsFunction::RunSync() {
152 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue()); 152 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
153 153
154 #define SET_STRING(id, idr) \ 154 #define SET_STRING(id, idr) \
155 dict->SetString(id, l10n_util::GetStringUTF16(idr)) 155 dict->SetString(id, l10n_util::GetStringUTF16(idr))
156 SET_STRING("page-title", IDS_FEEDBACK_REPORT_PAGE_TITLE); 156 SET_STRING("page-title", IDS_FEEDBACK_REPORT_PAGE_TITLE);
157 SET_STRING("additionalInfo", IDS_FEEDBACK_ADDITIONAL_INFO_LABEL);
157 SET_STRING("page-url", IDS_FEEDBACK_REPORT_URL_LABEL); 158 SET_STRING("page-url", IDS_FEEDBACK_REPORT_URL_LABEL);
158 SET_STRING("screenshot", IDS_FEEDBACK_SCREENSHOT_LABEL); 159 SET_STRING("screenshot", IDS_FEEDBACK_SCREENSHOT_LABEL);
159 SET_STRING("user-email", IDS_FEEDBACK_USER_EMAIL_LABEL); 160 SET_STRING("user-email", IDS_FEEDBACK_USER_EMAIL_LABEL);
160 #if defined(OS_CHROMEOS) 161 #if defined(OS_CHROMEOS)
161 const arc::ArcAuthService* auth_service = arc::ArcAuthService::Get(); 162 const arc::ArcAuthService* auth_service = arc::ArcAuthService::Get();
162 if (auth_service && auth_service->IsArcEnabled()) { 163 if (auth_service && auth_service->IsArcEnabled()) {
163 SET_STRING("sys-info", 164 SET_STRING("sys-info",
164 IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_AND_METRICS_CHKBOX_ARC); 165 IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_AND_METRICS_CHKBOX_ARC);
165 } else { 166 } else {
166 SET_STRING("sys-info", 167 SET_STRING("sys-info",
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 content::RecordAction( 334 content::RecordAction(
334 base::UserMetricsAction("Feedback.SrtPromptClosed")); 335 base::UserMetricsAction("Feedback.SrtPromptClosed"));
335 break; 336 break;
336 default: 337 default:
337 return RespondNow(Error("Invalid arugment.")); 338 return RespondNow(Error("Invalid arugment."));
338 } 339 }
339 return RespondNow(NoArguments()); 340 return RespondNow(NoArguments());
340 } 341 }
341 342
342 } // namespace extensions 343 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/feedback/css/feedback.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698