Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 229363002: Componentize TranslateUIDelegate (Closed)

Created:
6 years, 8 months ago by blundell
Modified:
6 years, 8 months ago
Reviewers:
droger, Nico
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Componentize TranslateUIDelegate Changes TranslateUIDelegate to: - Take in a TranslateClient and TranslateManager rather than a WebContents. - Go through TranslateDriver and TranslateClient APIs rather than talking directly to TranslateTabHelper. Moves TranslateUIDelegate into the Translate component. BUG=335084 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262961

Patch Set 1 #

Total comments: 6

Patch Set 2 : Response to review #

Patch Set 3 : Rebase #

Patch Set 4 : Fix Linux compile #

Patch Set 5 : Fix mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -474 lines) Patch
M chrome/browser/translate/translate_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_render_view_host_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
D chrome/browser/translate/translate_ui_delegate.h View 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/browser/translate/translate_ui_delegate.cc View 1 chunk +0 lines, -259 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/translate/translate_bubble_model_impl.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 1 2 3 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/translate.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/translate/core/browser/translate_ui_delegate.h View 1 2 3 4 chunks +16 lines, -15 lines 0 comments Download
A + components/translate/core/browser/translate_ui_delegate.cc View 1 2 3 11 chunks +43 lines, -51 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
blundell
Dependent on https://codereview.chromium.org/224723025/
6 years, 8 months ago (2014-04-09 08:03:52 UTC) #1
droger
https://codereview.chromium.org/229363002/diff/1/chrome/browser/translate/translate_tab_helper.h File chrome/browser/translate/translate_tab_helper.h (right): https://codereview.chromium.org/229363002/diff/1/chrome/browser/translate/translate_tab_helper.h#newcode98 chrome/browser/translate/translate_tab_helper.h:98: OVERRIDE; Nit: break after opening bracket. https://codereview.chromium.org/229363002/diff/1/components/translate/core/browser/translate_manager.cc File components/translate/core/browser/translate_manager.cc ...
6 years, 8 months ago (2014-04-09 08:31:24 UTC) #2
blundell
https://codereview.chromium.org/229363002/diff/1/chrome/browser/translate/translate_tab_helper.h File chrome/browser/translate/translate_tab_helper.h (right): https://codereview.chromium.org/229363002/diff/1/chrome/browser/translate/translate_tab_helper.h#newcode98 chrome/browser/translate/translate_tab_helper.h:98: OVERRIDE; On 2014/04/09 08:31:24, droger wrote: > Nit: break ...
6 years, 8 months ago (2014-04-09 08:49:26 UTC) #3
droger
lgtm
6 years, 8 months ago (2014-04-09 09:12:16 UTC) #4
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 8 months ago (2014-04-09 19:16:50 UTC) #5
blundell
The CQ bit was unchecked by blundell@chromium.org
6 years, 8 months ago (2014-04-09 19:17:50 UTC) #6
blundell
TBR=thakis for //chrome changes outside of //chrome/browser/translate
6 years, 8 months ago (2014-04-09 19:18:17 UTC) #7
blundell
TBR=thakis for //chrome changes outside of //chrome/browser/translate
6 years, 8 months ago (2014-04-09 19:18:19 UTC) #8
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 8 months ago (2014-04-09 19:18:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/229363002/70001
6 years, 8 months ago (2014-04-09 19:20:05 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 19:49:43 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel tryserver.chromium on linux_chromium_clang_dbg
6 years, 8 months ago (2014-04-09 19:49:44 UTC) #12
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 8 months ago (2014-04-09 20:06:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/229363002/70001
6 years, 8 months ago (2014-04-09 20:06:51 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 21:55:40 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-04-09 21:55:41 UTC) #16
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 8 months ago (2014-04-10 07:38:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/229363002/90001
6 years, 8 months ago (2014-04-10 07:38:15 UTC) #18
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 13:25:10 UTC) #19
Message was sent while issue was closed. 
Change committed as 262961

Powered by Google App Engine
This is Rietveld 408576698