Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1737)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 229363002: Componentize TranslateUIDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix mac Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/translate/translate_bubble_model_impl.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/translate/translate_bubble_view.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc
index f2c58f0d6406bb01fe30f944819ec233580aff74..ba6c6bd7bac67d0e51a0c70cf9ccad1de13c3b66 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc
@@ -17,12 +17,12 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/translate/translate_service.h"
#include "chrome/browser/translate/translate_tab_helper.h"
-#include "chrome/browser/translate/translate_ui_delegate.h"
#include "chrome/browser/ui/chrome_pages.h"
#include "chrome/browser/ui/translate/translate_bubble_model_impl.h"
#include "chrome/common/url_constants.h"
#include "components/translate/core/browser/translate_download_manager.h"
#include "components/translate/core/browser/translate_manager.h"
+#include "components/translate/core/browser/translate_ui_delegate.h"
#include "content/public/browser/web_contents.h"
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util.h"
@@ -141,8 +141,11 @@ void TranslateBubbleView::ShowBubble(views::View* anchor_view,
TranslateTabHelper::GetTranslateLanguages(web_contents,
&source_language, &target_language);
- scoped_ptr<TranslateUIDelegate> ui_delegate(
- new TranslateUIDelegate(web_contents, source_language, target_language));
+ scoped_ptr<TranslateUIDelegate> ui_delegate(new TranslateUIDelegate(
+ TranslateTabHelper::FromWebContents(web_contents),
+ TranslateTabHelper::GetManagerFromWebContents(web_contents),
+ source_language,
+ target_language));
scoped_ptr<TranslateBubbleModel> model(
new TranslateBubbleModelImpl(step, ui_delegate.Pass()));
TranslateBubbleView* view = new TranslateBubbleView(anchor_view,
« no previous file with comments | « chrome/browser/ui/translate/translate_bubble_model_impl.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698