|
Refactor NumericBuilder to HistogramBinBoundaries.
HistogramBinBoundaries still allows metrics to use the builder pattern,
but it's building only the bin boundaries, not the entire Histogram object.
The Histogram constructor now takes a unit and an optional HistogramBinBoundaries
object. Soon, Histogram will subsume name from Value, but that's it.
2 or 3 arguments is not enough to warrant applying the builder pattern to Histogram
construction.
HistogramBinBoundaries *are* complex enough to warrant the builder pattern, but
they are separate from the larger Histogram concept.
Metrics are all changed to say |new Histogram(unit, boundaries)|.
cpu_process_metric was incorrectly producing percentages between 0 and 100,
and was changed to 0 to 1.
BUG=catapult:#2685
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/17bda7618b6d6dd0814e494d762f20e85bc3fed0
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+383 lines, -471 lines) |
Patch |
|
M |
trace_processor/experimental/mappers/task_info_map_function.html
|
View
|
1
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
trace_processor/experimental/mappers/trace_stats.html
|
View
|
1
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/blink/gc_metric.html
|
View
|
1
2
3
4
|
3 chunks |
+7 lines, -11 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/cpu_process_metric.html
|
View
|
1
|
2 chunks |
+3 lines, -7 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/cpu_process_metric_test.html
|
View
|
1
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/metric_registry_test.html
|
View
|
1
|
3 chunks |
+9 lines, -12 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/sample_metric.html
|
View
|
1
|
1 chunk |
+1 line, -5 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/system_health/clock_sync_latency_metric.html
|
View
|
1
2
3
4
|
2 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/system_health/hazard_metric.html
|
View
|
1
|
2 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/system_health/loading_metric.html
|
View
|
1
2
3
4
|
1 chunk |
+7 lines, -6 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/system_health/long_tasks_metric.html
|
View
|
1
2
|
4 chunks |
+10 lines, -18 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/system_health/memory_metric.html
|
View
|
1
2
3
4
5
6
|
4 chunks |
+11 lines, -13 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/system_health/power_metric.html
|
View
|
1
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/system_health/rail_power_metric.html
|
View
|
1
|
2 chunks |
+8 lines, -17 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/system_health/responsiveness_metric.html
|
View
|
1
|
1 chunk |
+13 lines, -24 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/system_health/webview_startup_metric.html
|
View
|
1
|
1 chunk |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/tracing_metric.html
|
View
|
1
|
3 chunks |
+18 lines, -15 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/v8/execution_metric.html
|
View
|
1
|
7 chunks |
+41 lines, -23 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/metrics/v8/gc_metric.html
|
View
|
1
2
3
|
5 chunks |
+11 lines, -12 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/diagnostics/composition.html
|
View
|
1
|
2 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/diagnostics/composition_test.html
|
View
|
1
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/histogram.html
|
View
|
1
2
3
|
11 chunks |
+105 lines, -96 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/histogram_test.html
|
View
|
1
|
19 chunks |
+60 lines, -106 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/numeric.html
|
View
|
1
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/ui/composition_span_test.html
|
View
|
1
|
1 chunk |
+1 line, -5 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/ui/histogram_span_test.html
|
View
|
1
|
3 chunks |
+3 lines, -7 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/ui/numeric_stats_span_test.html
|
View
|
1
|
1 chunk |
+1 line, -5 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/ui/related_value_map_span_test.html
|
View
|
1
|
1 chunk |
+4 lines, -6 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/ui/related_value_set_span_test.html
|
View
|
1
|
1 chunk |
+4 lines, -6 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/ui/scalar_span_test.html
|
View
|
1
2
|
3 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/ui/value_set_table_test.html
|
View
|
1
|
7 chunks |
+14 lines, -9 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/ui/value_set_view_test.html
|
View
|
1
|
1 chunk |
+2 lines, -6 lines |
0 comments
|
Download
|
|
M |
tracing/tracing/value/value_set_test.html
|
View
|
1
2
3
4
|
4 chunks |
+5 lines, -12 lines |
0 comments
|
Download
|
Total messages: 29 (16 generated)
|