Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 229353002: Fixes issue 18099: missed type guard dependency in implicit getters. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/co19/co19-runtime.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 34836)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -3088,16 +3088,12 @@
for_instance.value(),
&node->field(),
AbstractType::ZoneHandle(node->field().type()));
- if (owner()->exit_collector() != NULL) {
- // While inlining into an optimized function, the field has
- // to be added to the list of guarded fields of the caller.
- if (node->field().guarded_cid() != kIllegalCid) {
- if (!node->field().is_nullable() ||
- (node->field().guarded_cid() == kNullCid)) {
- load->set_result_cid(node->field().guarded_cid());
- }
- FlowGraph::AddToGuardedFields(owner()->guarded_fields(), &node->field());
+ if (node->field().guarded_cid() != kIllegalCid) {
+ if (!node->field().is_nullable() ||
+ (node->field().guarded_cid() == kNullCid)) {
+ load->set_result_cid(node->field().guarded_cid());
}
+ FlowGraph::AddToGuardedFields(owner()->guarded_fields(), &node->field());
}
ReturnDefinition(load);
}
« no previous file with comments | « no previous file | tests/co19/co19-runtime.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698