Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: runtime/vm/flow_graph_builder.cc

Issue 229353002: Fixes issue 18099: missed type guard dependency in implicit getters. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tests/co19/co19-runtime.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_builder.h" 5 #include "vm/flow_graph_builder.h"
6 6
7 #include "lib/invocation_mirror.h" 7 #include "lib/invocation_mirror.h"
8 #include "vm/ast_printer.h" 8 #include "vm/ast_printer.h"
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/class_finalizer.h" 10 #include "vm/class_finalizer.h"
(...skipping 3070 matching lines...) Expand 10 before | Expand all | Expand 10 after
3081 3081
3082 void EffectGraphVisitor::VisitLoadInstanceFieldNode( 3082 void EffectGraphVisitor::VisitLoadInstanceFieldNode(
3083 LoadInstanceFieldNode* node) { 3083 LoadInstanceFieldNode* node) {
3084 ValueGraphVisitor for_instance(owner()); 3084 ValueGraphVisitor for_instance(owner());
3085 node->instance()->Visit(&for_instance); 3085 node->instance()->Visit(&for_instance);
3086 Append(for_instance); 3086 Append(for_instance);
3087 LoadFieldInstr* load = new LoadFieldInstr( 3087 LoadFieldInstr* load = new LoadFieldInstr(
3088 for_instance.value(), 3088 for_instance.value(),
3089 &node->field(), 3089 &node->field(),
3090 AbstractType::ZoneHandle(node->field().type())); 3090 AbstractType::ZoneHandle(node->field().type()));
3091 if (owner()->exit_collector() != NULL) { 3091 if (node->field().guarded_cid() != kIllegalCid) {
3092 // While inlining into an optimized function, the field has 3092 if (!node->field().is_nullable() ||
3093 // to be added to the list of guarded fields of the caller. 3093 (node->field().guarded_cid() == kNullCid)) {
3094 if (node->field().guarded_cid() != kIllegalCid) { 3094 load->set_result_cid(node->field().guarded_cid());
3095 if (!node->field().is_nullable() ||
3096 (node->field().guarded_cid() == kNullCid)) {
3097 load->set_result_cid(node->field().guarded_cid());
3098 }
3099 FlowGraph::AddToGuardedFields(owner()->guarded_fields(), &node->field());
3100 } 3095 }
3096 FlowGraph::AddToGuardedFields(owner()->guarded_fields(), &node->field());
3101 } 3097 }
3102 ReturnDefinition(load); 3098 ReturnDefinition(load);
3103 } 3099 }
3104 3100
3105 3101
3106 void EffectGraphVisitor::VisitStoreInstanceFieldNode( 3102 void EffectGraphVisitor::VisitStoreInstanceFieldNode(
3107 StoreInstanceFieldNode* node) { 3103 StoreInstanceFieldNode* node) {
3108 ValueGraphVisitor for_instance(owner()); 3104 ValueGraphVisitor for_instance(owner());
3109 node->instance()->Visit(&for_instance); 3105 node->instance()->Visit(&for_instance);
3110 Append(for_instance); 3106 Append(for_instance);
(...skipping 777 matching lines...) Expand 10 before | Expand all | Expand 10 after
3888 LanguageError::kError, 3884 LanguageError::kError,
3889 Heap::kNew, 3885 Heap::kNew,
3890 "FlowGraphBuilder Bailout: %s %s", 3886 "FlowGraphBuilder Bailout: %s %s",
3891 String::Handle(function.name()).ToCString(), 3887 String::Handle(function.name()).ToCString(),
3892 reason)); 3888 reason));
3893 Isolate::Current()->long_jump_base()->Jump(1, error); 3889 Isolate::Current()->long_jump_base()->Jump(1, error);
3894 } 3890 }
3895 3891
3896 3892
3897 } // namespace dart 3893 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | tests/co19/co19-runtime.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698