Issue 22935016: Introduce polymer transformers (inlined code extraction, inlining html imports,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22935016: Introduce polymer transformers (inlined code extraction, inlining html imports, (Closed)

Created:
7 years, 4 months ago by Siggi Cherem (dart-lang)

Modified:
7 years, 4 months ago

Reviewers:
Bob Nystrom, terry, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Introduce polymer transformers (inlined code extraction, inlining html imports, combining multiple script tags) R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=26495

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+972 lines, -5 lines)			Patch
A +	pkg/polymer/lib/src/transform.dart	View		1 chunk	+5 lines, -5 lines	0 comments	Download
A	pkg/polymer/lib/src/transform/code_extractor.dart	View	1	1 chunk	+46 lines, -0 lines	0 comments	Download
A	pkg/polymer/lib/src/transform/common.dart	View	1	1 chunk	+79 lines, -0 lines	0 comments	Download
A	pkg/polymer/lib/src/transform/import_inliner.dart	View	1	1 chunk	+91 lines, -0 lines	0 comments	Download
A	pkg/polymer/lib/src/transform/script_compactor.dart	View	1	1 chunk	+125 lines, -0 lines	0 comments	Download
M	pkg/polymer/test/run_all.dart	View		2 chunks	+6 lines, -0 lines	0 comments	Download
A	pkg/polymer/test/transform/code_extractor_test.dart	View		1 chunk	+82 lines, -0 lines	0 comments	Download
A	pkg/polymer/test/transform/common.dart	View	1	1 chunk	+97 lines, -0 lines	0 comments	Download
A	pkg/polymer/test/transform/import_inliner_test.dart	View		1 chunk	+352 lines, -0 lines	0 comments	Download
A	pkg/polymer/test/transform/script_compactor_test.dart	View	1	1 chunk	+89 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Siggi Cherem (dart-lang)

This the CL where I'd like to continue the review. You should be able to ...

7 years, 4 months ago (2013-08-21 20:36:46 UTC) #1

Siggi Cherem (dart-lang)

Committed patchset #2 manually as r26495 (presubmit successful).

7 years, 4 months ago (2013-08-22 00:24:51 UTC) #3

Siggi Cherem (dart-lang)

7 years, 4 months ago (2013-08-22 00:27:34 UTC) #4

Message was sent while issue was closed.

forgot to upload a new patch, but I included your suggestion on using
isolate.rootLibrary