Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2293373003: Change UI of settings button on IME menu: (Closed)

Created:
4 years, 3 months ago by Azure Wei
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Change UI of settings button on IME menu: When there's only one button, we show the gear icon with text. Otherwise, just show the icon directly. TBR=jamescook@chromium.org NOPRESUBMIT=true NOTRY=true BUG=641300 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2287453002 Cr-Commit-Position: refs/heads/master@{#414848} (cherry picked from commit 6bc89ebf6173622a65c685f633a0c35911d153b4)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -9 lines) Patch
M ash/ash_chromeos_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 7 chunks +58 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293373003/1
4 years, 3 months ago (2016-08-31 05:33:42 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 05:36:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698