Change UI of settings button on IME menu.

Change UI of settings button on IME menu:

When there's only one button, we show the gear icon with text. Otherwise, just show the icon directly.

BUG=641300
TEST=Verified on local build.

Committed: https://crrev.com/6bc89ebf6173622a65c685f633a0c35911d153b4
Cr-Commit-Position: refs/heads/master@{#414848}

[Azure Wei, 2016-08-26 10:38:53]

Description was changed from

==========
Change UI of settings button on IME menu.

BUG=641300
TEST=Verified on local build.
==========

to

==========
Change UI of settings button on IME menu:

When there's only one button, we show the gear icon with text. Otherwise, just
show the icon directly.

BUG=641300
TEST=Verified on local build.
==========

[Azure Wei, 2016-08-26 10:39:20]

The CQ bit was checked by azurewei@chromium.org to run a CQ dry run

[Azure Wei, 2016-08-26 10:39:28]

azurewei@chromium.org changed reviewers:
+ jamescook@chromium.org

[commit-bot: I haz the power, 2016-08-26 10:39:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 11:12:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 11:12:05]

Dry run: This issue passed the CQ dry run.

[Azure Wei, 2016-08-26 14:06:56]

Please review this cl. Thanks!

[James Cook, 2016-08-26 16:09:25]

LGTM with nits

https://codereview.chromium.org/2287453002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/ime_menu/ime_menu_tray.cc (right):

https://codereview.chromium.org/2287453002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:85: explicit
ImeSettingButtonView() {
no explicit.

Only do this with single-parameter constructors.
https://google.github.io/styleguide/cppguide.html#Implicit_Conversions

https://codereview.chromium.org/2287453002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:87:
ash::kTrayPopupPaddingHorizontal, 0,
no ash::

https://codereview.chromium.org/2287453002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:91: views::ImageView* icon
= new ash::FixedSizedImageView(
no ash::

https://codereview.chromium.org/2287453002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:94:
icon->set_id(test::kSettingsTrayItemViewId);
Do you have tests that need to look things up with this ID? If not, don't
reference test code in production code.

https://codereview.chromium.org/2287453002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:106: //
ash::ActionableView.
Just "ActionableView:"

[Azure Wei, 2016-08-26 22:09:57]

https://codereview.chromium.org/2287453002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/ime_menu/ime_menu_tray.cc (right):

https://codereview.chromium.org/2287453002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:85: explicit
ImeSettingButtonView() {
On 2016/08/26 16:09:24, James Cook wrote:
> no explicit.
> 
> Only do this with single-parameter constructors.
> https://google.github.io/styleguide/cppguide.html#Implicit_Conversions

Done.

https://codereview.chromium.org/2287453002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:87:
ash::kTrayPopupPaddingHorizontal, 0,
On 2016/08/26 16:09:24, James Cook wrote:
> no ash::

Done.

https://codereview.chromium.org/2287453002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:91: views::ImageView* icon
= new ash::FixedSizedImageView(
On 2016/08/26 16:09:24, James Cook wrote:
> no ash::

Done.

https://codereview.chromium.org/2287453002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:94:
icon->set_id(test::kSettingsTrayItemViewId);
On 2016/08/26 16:09:24, James Cook wrote:
> Do you have tests that need to look things up with this ID? If not, don't
> reference test code in production code.

Removed.

https://codereview.chromium.org/2287453002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:106: //
ash::ActionableView.
On 2016/08/26 16:09:24, James Cook wrote:
> Just "ActionableView:"

Done.

[Azure Wei, 2016-08-26 22:10:01]

The CQ bit was checked by azurewei@chromium.org

[Azure Wei, 2016-08-26 22:10:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2287453002/#ps20001
(title: "Addressed nits.")

[commit-bot: I haz the power, 2016-08-26 22:10:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 22:57:49]

Description was changed from

==========
Change UI of settings button on IME menu:

When there's only one button, we show the gear icon with text. Otherwise, just
show the icon directly.

BUG=641300
TEST=Verified on local build.
==========

to

==========
Change UI of settings button on IME menu:

When there's only one button, we show the gear icon with text. Otherwise, just
show the icon directly.

BUG=641300
TEST=Verified on local build.
==========

[commit-bot: I haz the power, 2016-08-26 22:57:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-26 23:01:19]

Description was changed from

==========
Change UI of settings button on IME menu:

When there's only one button, we show the gear icon with text. Otherwise, just
show the icon directly.

BUG=641300
TEST=Verified on local build.
==========

to

==========
Change UI of settings button on IME menu:

When there's only one button, we show the gear icon with text. Otherwise, just
show the icon directly.

BUG=641300
TEST=Verified on local build.

Committed: https://crrev.com/6bc89ebf6173622a65c685f633a0c35911d153b4
Cr-Commit-Position: refs/heads/master@{#414848}
==========

[commit-bot: I haz the power, 2016-08-26 23:01:20]

Patchset 2 (id:??) landed as
https://crrev.com/6bc89ebf6173622a65c685f633a0c35911d153b4
Cr-Commit-Position: refs/heads/master@{#414848}