third_party/WebKit/Source/core/editing/FrameCaret.h - Issue 2293293003: Make CaretBase a DisplayItemClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameCaret.h

Issue 2293293003: Make CaretBase a DisplayItemClient. (Closed)

Patch Set: Fix caret invalidation when style changes. Update test expectations. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameCaret.h

diff --git a/third_party/WebKit/Source/core/editing/FrameCaret.h b/third_party/WebKit/Source/core/editing/FrameCaret.h

index 5af1d58c408f28bdc2ae1460e61aacc7837e496c..16bc71e7e3d226504d0d8f5706c5e573405332ed 100644

--- a/third_party/WebKit/Source/core/editing/FrameCaret.h

+++ b/third_party/WebKit/Source/core/editing/FrameCaret.h

@@ -52,7 +52,7 @@ public:

void setCaretVisibility(CaretVisibility) override;

bool isCaretBoundsDirty() const { return m_caretRectDirty; }

void setCaretRectNeedsUpdate();

- void invalidateCaretRect();

+ void invalidateCaretRect(bool forceInvalidation);

chrishtr 2016/09/01 23:45:58 Document briefly.

wkorman 2016/09/02 00:02:46 Done.

IntRect absoluteCaretBounds();

bool shouldShowBlockCursor() const { return m_shouldShowBlockCursor; }