third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-mse.html - Issue 2293273002: Add a download button to the media player

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-mse.html

Issue 2293273002: Add a download button to the media player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media-controls

Patch Set: added tests for mse & mediastream Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-mediastream.html ('k') | third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-correct-ordering.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-mse.html

diff --git a/third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-mse.html b/third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-mse.html

new file mode 100644

index 0000000000000000000000000000000000000000..0a950cc91340d2b0a225572686dd16cf621afa1a

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-mse.html

@@ -0,0 +1,20 @@

+<!DOCTYPE HTML>

+<title>Download button should not appear for MSE videos.</title>

+<script src="../resources/testharness.js"></script>

+<script src="../resources/testharnessreport.js"></script>

+<script src="media-controls.js"></script>

+<video controls></video>

+<script>

+async_test(function(t) {

+ var v = document.querySelector('video');

+ v.src = "blob:http://foo.bar.com/12345678";

+ var controlID = "-internal-download-button";

+ var downloadButton = mediaControlsElement(internals.shadowRoot(v).firstChild, controlID);

+ setTimeout(t.step_func_done(function() {

+ assert_equals(getComputedStyle(downloadButton).display, "none");

+ v.srcObject = null;

mlamouri (slow - plz ping) 2016/09/12 17:33:07 Remove `v.srcObject=null`

kdsilva 2016/09/12 17:37:54 Done.

+ }), 0);

+});

+</script>