third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-mse.html - Issue 2293273002: Add a download button to the media player

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-mse.html

Issue 2293273002: Add a download button to the media player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media-controls

Patch Set: added tests for mse & mediastream Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <title>Download button should not appear for MSE videos.</title>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="media-controls.js"></script>

	6 <video controls></video>

	7 <script>

	8

	9 async_test(function(t) {

	10 var v = document.querySelector('video');

	11 v.src = "blob:http://foo.bar.com/12345678";

	12

	13 var controlID = "-internal-download-button";

	14 var downloadButton = mediaControlsElement(internals.shadowRoot(v).firstChild, controlID);

	15 setTimeout(t.step_func_done(function() {

	16 assert_equals(getComputedStyle(downloadButton).display, "none");

	17 v.srcObject = null;
	mlamouri (slow - plz ping) 2016/09/12 17:33:07 Remove `v.srcObject=null` Remove `v.srcObject=null` kdsilva 2016/09/12 17:37:54 Done. Show quoted text On 2016/09/12 17:33:07, mlamouri wrote: > Remove `v.srcObject=null` Done.
	18 }), 0);

	19 });

	20 </script>

OLD	NEW