Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2293253004: [ARMv8] ARMv8 builds are capable of ARMv7 instructions. (Closed)

Created:
4 years, 3 months ago by slan
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARMv8] ARMv8 builds are capable of ARMv7 instructions. Correct a small bug which throws a compile-time assertion for ARMv8 builds since this change: https://codereview.chromium.org/2223433002 This does not add full support for ARMv8 instructions; it simply sets the CAN_USE_ARMV7_INSTRUCTIONS define on ARMv8 builds. BUG= Committed: https://crrev.com/efecae18b8b24feb05f70704b90587c0bdbff9b6 Cr-Commit-Position: refs/heads/master@{#39087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
slan
Hey all, please take a quick look at this bug fix. It's breaking Cast ARMv8 ...
4 years, 3 months ago (2016-08-31 15:28:43 UTC) #2
jbramley
On 2016/08/31 15:28:43, slan wrote: > Hey all, please take a quick look at this ...
4 years, 3 months ago (2016-08-31 15:40:41 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-01 12:18:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293253004/1
4 years, 3 months ago (2016-09-01 13:29:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 13:31:40 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 13:31:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efecae18b8b24feb05f70704b90587c0bdbff9b6
Cr-Commit-Position: refs/heads/master@{#39087}

Powered by Google App Engine
This is Rietveld 408576698