BUILD.gn - Issue 2293253004: [ARMv8] ARMv8 builds are capable of ARMv7 instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 2293253004: [ARMv8] ARMv8 builds are capable of ARMv7 instructions. (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index d1e11c8830b191802613628ce500ac3d9e430c58..dffb5c00e6dd8d217eb180b49dd5dc6be934b10b 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -200,7 +200,7 @@ config("toolchain") {

if (v8_current_cpu == "arm") {

defines += [ "V8_TARGET_ARCH_ARM" ]

- if (arm_version == 7) {

+ if (arm_version >= 7) {

defines += [ "CAN_USE_ARMV7_INSTRUCTIONS" ]

}

if (arm_fpu == "vfpv3-d16") {

« no previous file with comments | « no previous file | no next file » | no next file with comments »