Eliminate use of GetCopyWithRotationApplied.

Eliminate use of GetCopyWithRotationApplied.

Replaced by webrtc::I420Buffer::Rotate.

BUG=webrtc:5682
Committed: https://crrev.com/0a2d5600eb9d487509faace3b6886989edff8a56
Cr-Commit-Position: refs/heads/master@{#415909}

[nisse-chromium (ooo August 14), 2016-08-31 08:19:16]

nisse@chromium.org changed reviewers:
+ perkj@chromium.org

[nisse-chromium (ooo August 14), 2016-08-31 08:19:17]

This is the only use left. I think.

[perkj_chrome, 2016-09-01 06:44:29]

https://codereview.chromium.org/2293253003/diff/1/content/renderer/media/webr...
File content/renderer/media/webrtc/media_stream_remote_video_source.cc (right):

https://codereview.chromium.org/2293253003/diff/1/content/renderer/media/webr...
content/renderer/media/webrtc/media_stream_remote_video_source.cc:127: buffer =
webrtc::I420Buffer::Rotate(incoming_frame.video_frame_buffer(),
Can you check if video_frame->metadata()->SetRotation() can be used here
instead?  That will probably save a bit of processing but it requires all use
case to support it. Ie, rendering, recording, and sending this frame on a pc
again. 

Might want to file a separate bug on this if it is intended to work.

[nisse-chromium (ooo August 14), 2016-09-01 07:09:09]

https://codereview.chromium.org/2293253003/diff/1/content/renderer/media/webr...
File content/renderer/media/webrtc/media_stream_remote_video_source.cc (right):

https://codereview.chromium.org/2293253003/diff/1/content/renderer/media/webr...
content/renderer/media/webrtc/media_stream_remote_video_source.cc:127: buffer =
webrtc::I420Buffer::Rotate(incoming_frame.video_frame_buffer(),
On 2016/09/01 06:44:28, perkj_chrome wrote:
> Can you check if video_frame->metadata()->SetRotation() can be used here
> instead?  That will probably save a bit of processing but it requires all use
> case to support it. Ie, rendering, recording, and sending this frame on a pc
> again. 
> 
> Might want to file a separate bug on this if it is intended to work.

There's only one call to GetRotation, in WebMediaPlayerMS. There, it is passed
on to the VideoLayer and VideoLayerImpl classes. Unclear how it is used, I tried
hardcoding the rotation to media::VIDEO_ROTATION_90 here, but that doesn't seem
to have any effect (tested with
https://webrtc.github.io/samples/src/content/peerconnection/pc1/).

[perkj_chrome, 2016-09-01 07:19:13]

On 2016/09/01 07:09:09, nisse-chromium wrote:
>
https://codereview.chromium.org/2293253003/diff/1/content/renderer/media/webr...
> File content/renderer/media/webrtc/media_stream_remote_video_source.cc
(right):
> 
>
https://codereview.chromium.org/2293253003/diff/1/content/renderer/media/webr...
> content/renderer/media/webrtc/media_stream_remote_video_source.cc:127: buffer
=
> webrtc::I420Buffer::Rotate(incoming_frame.video_frame_buffer(),
> On 2016/09/01 06:44:28, perkj_chrome wrote:
> > Can you check if video_frame->metadata()->SetRotation() can be used here
> > instead?  That will probably save a bit of processing but it requires all
use
> > case to support it. Ie, rendering, recording, and sending this frame on a pc
> > again. 
> > 
> > Might want to file a separate bug on this if it is intended to work.
> 
> There's only one call to GetRotation, in WebMediaPlayerMS. There, it is passed
> on to the VideoLayer and VideoLayerImpl classes. Unclear how it is used, I
tried
> hardcoding the rotation to media::VIDEO_ROTATION_90 here, but that doesn't
seem
> to have any effect (tested with
> https://webrtc.github.io/samples/src/content/peerconnection/pc1/).

ok, lgtm in that case.

[nisse-chromium (ooo August 14), 2016-09-01 07:20:14]

The CQ bit was checked by nisse@chromium.org

[commit-bot: I haz the power, 2016-09-01 07:20:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 08:13:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-01 08:16:44]

Description was changed from

==========
Eliminate use of GetCopyWithRotationApplied.

Replaced by webrtc::I420Buffer::Rotate.

BUG=webrtc:5682
==========

to

==========
Eliminate use of GetCopyWithRotationApplied.

Replaced by webrtc::I420Buffer::Rotate.

BUG=webrtc:5682

Committed: https://crrev.com/0a2d5600eb9d487509faace3b6886989edff8a56
Cr-Commit-Position: refs/heads/master@{#415909}
==========

[commit-bot: I haz the power, 2016-09-01 08:16:45]

Patchset 1 (id:??) landed as
https://crrev.com/0a2d5600eb9d487509faace3b6886989edff8a56
Cr-Commit-Position: refs/heads/master@{#415909}