Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Unified Diff: content/renderer/media/webrtc/media_stream_remote_video_source.cc

Issue 2293253003: Eliminate use of GetCopyWithRotationApplied. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/webrtc/media_stream_remote_video_source.cc
diff --git a/content/renderer/media/webrtc/media_stream_remote_video_source.cc b/content/renderer/media/webrtc/media_stream_remote_video_source.cc
index 30c25baa3dbf659b70c4316d13b9aecdd8333b1c..8f1e0751df92974e28f4f87f23a793ccef1f5ea8 100644
--- a/content/renderer/media/webrtc/media_stream_remote_video_source.cc
+++ b/content/renderer/media/webrtc/media_stream_remote_video_source.cc
@@ -124,10 +124,9 @@ void MediaStreamRemoteVideoSource::RemoteVideoSourceDelegate::OnFrame(
WebRTCToMediaVideoRotation(incoming_frame.rotation()));
}
} else {
- // Note that the GetCopyWithRotationApplied returns a pointer to a
- // frame owned by incoming_frame.
- buffer =
- incoming_frame.GetCopyWithRotationApplied()->video_frame_buffer();
+ buffer = webrtc::I420Buffer::Rotate(incoming_frame.video_frame_buffer(),
perkj_chrome 2016/09/01 06:44:28 Can you check if video_frame->metadata()->SetRotat
nisse-chromium (ooo August 14) 2016/09/01 07:09:09 There's only one call to GetRotation, in WebMediaP
+ incoming_frame.rotation());
+
gfx::Size size(buffer->width(), buffer->height());
// Make a shallow copy. Both |frame| and |video_frame| will share a single
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698