Move SVGAnimateElement::findElementInstances to SVGElement.cpp

Move SVGAnimateElement::findElementInstances to SVGElement.cpp

There's now only a single user of this function, so fold the function
into that one.

BUG=640676
Committed: https://crrev.com/1792ae27e0a2a97863e839532bbfe81117be21ac
Cr-Commit-Position: refs/heads/master@{#415901}

[fs, 2016-08-30 20:58:09]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 20:58:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-08-30 22:17:48]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[pdr., 2016-08-30 23:06:52]

https://codereview.chromium.org/2293173003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGElement.cpp (right):

https://codereview.chromium.org/2293173003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGElement.cpp:248: static
SVGElementInstances findElementInstances(SVGElement* element)
This looks great. WDYT about taking it one step further and merging into
forSelfAndInstances?

Something like:
template<typename T>
static void forSelfAndInstances(SVGElement* element, T callback)
{
    SVGElement::InstanceUpdateBlocker blocker(element);
    callback(element);
    for (SVGElement* instance : element->instancesForElement())
        callback(instance);
}

[commit-bot: I haz the power, 2016-08-31 00:19:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 00:19:59]

Dry run: This issue passed the CQ dry run.

[fs, 2016-08-31 08:59:56]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 09:00:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-08-31 09:00:35]

https://codereview.chromium.org/2293173003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGElement.cpp (right):

https://codereview.chromium.org/2293173003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGElement.cpp:248: static
SVGElementInstances findElementInstances(SVGElement* element)
On 2016/08/30 at 23:06:51, pdr. wrote:
> This looks great. WDYT about taking it one step further and merging into
forSelfAndInstances?
> 
> Something like:
> template<typename T>
> static void forSelfAndInstances(SVGElement* element, T callback)
> {
>     SVGElement::InstanceUpdateBlocker blocker(element);
>     callback(element);
>     for (SVGElement* instance : element->instancesForElement())
>         callback(instance);
> }

I was considering doing that separately (in case there happened to be a instance
invalidation lurking - although there shouldn't be because of the blocker.) I
guess I can fold it in though.

[commit-bot: I haz the power, 2016-08-31 12:05:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 12:05:20]

Dry run: This issue passed the CQ dry run.

[fs, 2016-08-31 15:54:56]

Description was changed from

==========
Move SVGAnimateElement::findElementInstances to SVGElement.cpp

There's now only a single user of this function, so move it so that it
is adjacent to that one.

BUG=640676
==========

to

==========
Move SVGAnimateElement::findElementInstances to SVGElement.cpp

There's now only a single user of this function, so fold the function
into that one.

BUG=640676
==========

[pdr., 2016-09-01 05:39:23]

On 2016/08/31 at 09:00:35, fs wrote:
>
https://codereview.chromium.org/2293173003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/svg/SVGElement.cpp (right):
> 
>
https://codereview.chromium.org/2293173003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/svg/SVGElement.cpp:248: static
SVGElementInstances findElementInstances(SVGElement* element)
> On 2016/08/30 at 23:06:51, pdr. wrote:
> > This looks great. WDYT about taking it one step further and merging into
forSelfAndInstances?
> > 
> > Something like:
> > template<typename T>
> > static void forSelfAndInstances(SVGElement* element, T callback)
> > {
> >     SVGElement::InstanceUpdateBlocker blocker(element);
> >     callback(element);
> >     for (SVGElement* instance : element->instancesForElement())
> >         callback(instance);
> > }
> 
> I was considering doing that separately (in case there happened to be a
instance invalidation lurking - although there shouldn't be because of the
blocker.) I guess I can fold it in though.

LGTM++

[fs, 2016-09-01 07:50:17]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-09-01 07:50:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 07:54:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-01 07:56:24]

Description was changed from

==========
Move SVGAnimateElement::findElementInstances to SVGElement.cpp

There's now only a single user of this function, so fold the function
into that one.

BUG=640676
==========

to

==========
Move SVGAnimateElement::findElementInstances to SVGElement.cpp

There's now only a single user of this function, so fold the function
into that one.

BUG=640676

Committed: https://crrev.com/1792ae27e0a2a97863e839532bbfe81117be21ac
Cr-Commit-Position: refs/heads/master@{#415901}
==========

[commit-bot: I haz the power, 2016-09-01 07:56:25]

Patchset 2 (id:??) landed as
https://crrev.com/1792ae27e0a2a97863e839532bbfe81117be21ac
Cr-Commit-Position: refs/heads/master@{#415901}