Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 2293103002: VM: Remove unecessary dead code from flow-graph builder. (Closed)

Created:
4 years, 3 months ago by Florian Schneider
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Remove unecessary dead code from flow-graph builder. We already recognize typed list factories and mark them using is_known_list_constructor_. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/442fa8e7bc8cc9af134a7606dccbe99465a0aea5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -42 lines) Patch
M runtime/vm/flow_graph_builder.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M runtime/vm/intermediate_language.h View 4 chunks +1 line, -9 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 3 months ago (2016-08-30 17:39:48 UTC) #2
Vyacheslav Egorov (Google)
LGTM!
4 years, 3 months ago (2016-08-30 18:03:37 UTC) #3
Florian Schneider
4 years, 3 months ago (2016-08-30 18:14:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
442fa8e7bc8cc9af134a7606dccbe99465a0aea5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698