Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 2293103002: VM: Remove unecessary dead code from flow-graph builder. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index 0bcf854c0c61c29462883740a43dca33837e05be..6ac47b80e3f930d349e5ef254c03bef06c94de6d 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -2656,30 +2656,6 @@ void EffectGraphVisitor::VisitInstanceCallNode(InstanceCallNode* node) {
}
-static bool IsNativeListFactory(const Function& function) {
- switch (function.recognized_kind()) {
- case MethodRecognizer::kTypedData_Int8Array_factory:
- case MethodRecognizer::kTypedData_Uint8Array_factory:
- case MethodRecognizer::kTypedData_Uint8ClampedArray_factory:
- case MethodRecognizer::kTypedData_Int16Array_factory:
- case MethodRecognizer::kTypedData_Uint16Array_factory:
- case MethodRecognizer::kTypedData_Int32Array_factory:
- case MethodRecognizer::kTypedData_Uint32Array_factory:
- case MethodRecognizer::kTypedData_Int64Array_factory:
- case MethodRecognizer::kTypedData_Uint64Array_factory:
- case MethodRecognizer::kTypedData_Float32Array_factory:
- case MethodRecognizer::kTypedData_Float64Array_factory:
- case MethodRecognizer::kTypedData_Float32x4Array_factory:
- case MethodRecognizer::kTypedData_Int32x4Array_factory:
- case MethodRecognizer::kTypedData_Float64x2Array_factory:
- return true;
- default:
- break;
- }
- return false;
-}
-
-
// <Expression> ::= StaticCall { function: Function
// arguments: <ArgumentList> }
void EffectGraphVisitor::VisitStaticCallNode(StaticCallNode* node) {
@@ -2692,9 +2668,6 @@ void EffectGraphVisitor::VisitStaticCallNode(StaticCallNode* node) {
node->arguments()->names(),
arguments,
owner()->ic_data_array());
- if (node->function().is_native() && IsNativeListFactory(node->function())) {
- call->set_is_native_list_factory(true);
- }
if (node->function().recognized_kind() != MethodRecognizer::kUnknown) {
call->set_result_cid(MethodRecognizer::ResultCid(node->function()));
}
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698