Backtrace related symbols must be included for uclibc

src/base/debug/stack_trace_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Slightly adapted for inclusion in V8.
 // Copyright 2016 the V8 project authors. All rights reserved.
 
 #include "src/base/debug/stack_trace.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <signal.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <sys/param.h>
 #include <sys/stat.h>
 #include <sys/types.h>
 #include <unistd.h>
 
 #include <map>
 #include <memory>
 #include <ostream>
 #include <string>
 #include <vector>
 
-#if V8_LIBC_GLIBC || V8_OS_BSD
+#if V8_LIBC_GLIBC || V8_OS_BSD || V8_LIBC_UCLIBC
 #include <cxxabi.h>
 #include <execinfo.h>
 #endif
 #if V8_OS_MACOSX
 #include <AvailabilityMacros.h>
 #endif
 
 #include "src/base/build_config.h"
 #include "src/base/free_deleter.h"
 #include "src/base/logging.h"
@@ skipping 31 matching lines @@
 
 // Demangles C++ symbols in the given text. Example:
 //
 // "out/Debug/base_unittests(_ZN10StackTraceC1Ev+0x20) [0x817778c]"
 // =>
 // "out/Debug/base_unittests(StackTrace::StackTrace()+0x20) [0x817778c]"
 void DemangleSymbols(std::string* text) {
   // Note: code in this function is NOT async-signal safe (std::string uses
   // malloc internally).
 
 #if V8_LIBC_GLIBC || V8_OS_BSD

[rmcilroy, 2016/09/05 10:33:49]

Are you also able to compile this block of code with ublibc?

[landell, 2016/09/05 11:39:28]

Actually I am. Seems as this is related to cxxabi.h rather than execinfo.h
though and seems like cxxabi.h is part of gcc, rather than glibc/uclibc.
We have a custom made toolchain so I am not sure that this would work for every
uclibc platform.

In any case, it works for me so if you want me I can make similar change here as
well.

[rmcilroy, 2016/09/05 14:00:17]

It would be good to keep it consistent, so please change it here too (also
change the #endif comment on line 117).

[landell, 2016/09/06 07:11:21]

Done.

 
   std::string::size_type search_from = 0;
   while (search_from < text->size()) {
     // Look for the start of a mangled symbol, from search_from.
     std::string::size_type mangled_start =
         text->find(kMangledSymbolPrefix, search_from);
     if (mangled_start == std::string::npos) {
       break;  // Mangled symbol not found.
     }
 
@@ skipping 346 matching lines @@
     *start++ = ch;
   }
   return buf;
 }
 
 }  // namespace internal
 
 }  // namespace debug
 }  // namespace base
 }  // namespace v8