Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 229293002: [Win] Move profile related UI from ui/views/ to ui/views/profiles (Closed)

Created:
6 years, 8 months ago by noms (inactive)
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Win] Move profile related UI from ui/views/ to ui/views/profiles BUG=NONE TEST=Existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262654

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -3969 lines) Patch
D chrome/browser/ui/views/avatar_label.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/ui/views/avatar_label.cc View 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/browser/ui/views/avatar_menu_bubble_view.h View 1 chunk +0 lines, -136 lines 0 comments Download
D chrome/browser/ui/views/avatar_menu_bubble_view.cc View 1 chunk +0 lines, -813 lines 0 comments Download
D chrome/browser/ui/views/avatar_menu_button.h View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/ui/views/avatar_menu_button.cc View 1 chunk +0 lines, -120 lines 0 comments Download
D chrome/browser/ui/views/avatar_menu_button_browsertest.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/views/new_avatar_button.h View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/ui/views/new_avatar_button.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D chrome/browser/ui/views/new_avatar_menu_button_browsertest.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/ui/views/profile_chooser_view.h View 1 chunk +0 lines, -210 lines 0 comments Download
D chrome/browser/ui/views/profile_chooser_view.cc View 1 chunk +0 lines, -1114 lines 0 comments Download
D chrome/browser/ui/views/profile_reset_bubble_view.h View 1 chunk +0 lines, -138 lines 0 comments Download
D chrome/browser/ui/views/profile_reset_bubble_view.cc View 1 chunk +0 lines, -446 lines 0 comments Download
A + chrome/browser/ui/views/profiles/avatar_label.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/profiles/avatar_label.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/profiles/avatar_menu_bubble_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/profiles/avatar_menu_button.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/profiles/avatar_menu_button.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/profiles/avatar_menu_button_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/views/profiles/new_avatar_button.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/profiles/new_avatar_button.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/profiles/new_avatar_menu_button_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/views/profiles/profile_chooser_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/profiles/profile_chooser_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/views/profiles/profile_reset_bubble_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/profiles/profile_reset_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/profiles/user_manager_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/profiles/user_manager_view.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/views/user_manager_view.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/ui/views/user_manager_view.cc View 1 chunk +0 lines, -155 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 4 chunks +14 lines, -14 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 31 (0 generated)
noms (inactive)
Hi Scott, Here's my good karma refactoring of the week :) I've moved all the ...
6 years, 8 months ago (2014-04-08 21:39:13 UTC) #1
sky
Rubber stamp LGTM
6 years, 8 months ago (2014-04-08 23:45:11 UTC) #2
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 8 months ago (2014-04-09 02:45:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 02:46:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 04:41:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 04:47:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 04:52:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 04:57:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 06:43:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 06:50:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 06:56:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 07:03:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 07:09:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 07:17:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 07:23:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 07:29:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 07:37:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 07:45:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 07:51:56 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 07:59:38 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 08:06:27 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 08:13:50 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 09:06:12 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 09:14:29 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 09:21:53 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 09:29:36 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 09:41:49 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 09:50:35 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 11:10:39 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229293002/20001
6 years, 8 months ago (2014-04-09 11:22:09 UTC) #30
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 12:22:36 UTC) #31
Message was sent while issue was closed. 
Change committed as 262654

Powered by Google App Engine
This is Rietveld 408576698