Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: base/file_util_posix.cc

Issue 22929021: Converge file_util::GetFileInfo and base::GetPlaformFileInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nacl? Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/file_util_unittest.cc » ('j') | base/platform_file_posix.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_util_posix.cc
diff --git a/base/file_util_posix.cc b/base/file_util_posix.cc
index 762700ae42c11d42e39bffaf89aaf4472a704dd9..28d582b3a07521ca88d41ec37b20338366632816 100644
--- a/base/file_util_posix.cc
+++ b/base/file_util_posix.cc
@@ -570,24 +570,30 @@ bool IsLink(const FilePath& file_path) {
return false;
}
-bool GetFileInfo(const FilePath& file_path, base::PlatformFileInfo* results) {
+bool GetFileInfo(const FilePath& file_path, base::PlatformFileInfo* info) {
+ if (!info)
+ return false;
+
stat_wrapper_t file_info;
if (CallStat(file_path.value().c_str(), &file_info) != 0)
return false;
- results->is_directory = S_ISDIR(file_info.st_mode);
- results->size = file_info.st_size;
+
+ info->is_directory = S_ISDIR(file_info.st_mode);
+ info->is_symbolic_link = S_ISLNK(file_info.st_mode);
+ info->size = file_info.st_size;
+
#if defined(OS_MACOSX)
- results->last_modified = base::Time::FromTimeSpec(file_info.st_mtimespec);
- results->last_accessed = base::Time::FromTimeSpec(file_info.st_atimespec);
- results->creation_time = base::Time::FromTimeSpec(file_info.st_ctimespec);
+ info->last_modified = base::Time::FromTimeSpec(file_info.st_mtimespec);
+ info->last_accessed = base::Time::FromTimeSpec(file_info.st_atimespec);
+ info->creation_time = base::Time::FromTimeSpec(file_info.st_ctimespec);
#elif defined(OS_ANDROID)
- results->last_modified = base::Time::FromTimeT(file_info.st_mtime);
- results->last_accessed = base::Time::FromTimeT(file_info.st_atime);
- results->creation_time = base::Time::FromTimeT(file_info.st_ctime);
+ info->last_modified = base::Time::FromTimeT(file_info.st_mtime);
+ info->last_accessed = base::Time::FromTimeT(file_info.st_atime);
+ info->creation_time = base::Time::FromTimeT(file_info.st_ctime);
#else
- results->last_modified = base::Time::FromTimeSpec(file_info.st_mtim);
- results->last_accessed = base::Time::FromTimeSpec(file_info.st_atim);
- results->creation_time = base::Time::FromTimeSpec(file_info.st_ctim);
+ info->last_modified = base::Time::FromTimeSpec(file_info.st_mtim);
+ info->last_accessed = base::Time::FromTimeSpec(file_info.st_atim);
+ info->creation_time = base::Time::FromTimeSpec(file_info.st_ctim);
#endif
return true;
}
« no previous file with comments | « no previous file | base/file_util_unittest.cc » ('j') | base/platform_file_posix.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698