Issue 22929011: Move productSub/vendor/vendorSub to Navigator class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22929011: Move productSub/vendor/vendorSub to Navigator class (Closed)

Created:
7 years, 4 months ago by do-not-use

Modified:
7 years, 4 months ago

Reviewers:
haraken, arv (Not doing code reviews)

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move productSub/vendor/vendorSub to Navigator class Move productSub/vendor/vendorSub getters from NavigatorBase to Navigator as this is not shared with WorkerNavigator nor do we intent to since this is an old non-standard API. Also measure usage for this non-standard API to help us determine if we can deprecate them. R=arv@chromium.org, haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156399

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -38 lines)			Patch
M	Source/core/page/Navigator.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/page/Navigator.cpp	View	2 chunks	+27 lines, -0 lines	0 comments	Download
M	Source/core/page/Navigator.idl	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	Source/core/page/NavigatorBase.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/core/page/NavigatorBase.cpp	View	2 chunks	+0 lines, -28 lines	0 comments	Download
M	Source/core/page/UseCounter.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

LGTM I would also have been fine with DeprecateAs

7 years, 4 months ago (2013-08-20 13:59:00 UTC) #2

do-not-use

Based on discussion from: https://codereview.chromium.org/22927015

7 years, 4 months ago (2013-08-20 13:59:12 UTC) #3

do-not-use

7 years, 4 months ago (2013-08-20 14:35:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r156399 (presubmit successful).

Expand Messages | Collapse Messages