default to device type of last build if no device type is given

default to device type of last build if no device type is given

R=borenet@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10807

[borenet, 2013-08-19 20:30:50]

https://codereview.chromium.org/22929006/diff/1/platform_tools/android/bin/an...
File platform_tools/android/bin/android_make (right):

https://codereview.chromium.org/22929006/diff/1/platform_tools/android/bin/an...
platform_tools/android/bin/android_make:9: fi
I'm confused - why do we want to remove this?

https://codereview.chromium.org/22929006/diff/1/platform_tools/android/bin/an...
File platform_tools/android/bin/android_setup.sh (right):

https://codereview.chromium.org/22929006/diff/1/platform_tools/android/bin/an...
platform_tools/android/bin/android_setup.sh:29: if [ -z "$DEVICE_ID" ]
Why not do this block where the previous default was set?  That way, if "-d" is
supplied, it can take precedence over either default.

https://codereview.chromium.org/22929006/diff/1/platform_tools/android/bin/an...
platform_tools/android/bin/android_setup.sh:35: echo "INFO: no target device
type was specified so using the default 'arm_v7'"
Use "${DEVICE_ID}" instead of "arm_v7"?

https://codereview.chromium.org/22929006/diff/1/platform_tools/android/bin/an...
platform_tools/android/bin/android_setup.sh:38: echo "INFO: no target device
type was specified so using the device from the most recent build"
Include $DEVICE_ID?

[djsollen, 2013-08-19 20:55:04]

https://codereview.chromium.org/22929006/diff/1/platform_tools/android/bin/an...
File platform_tools/android/bin/android_make (right):

https://codereview.chromium.org/22929006/diff/1/platform_tools/android/bin/an...
platform_tools/android/bin/android_make:9: fi
On 2013/08/19 20:30:50, borenet wrote:
> I'm confused - why do we want to remove this?

We need to remove it or android_setup will default to the device_id stored in
this file instead of the arm_v7 default.

[borenet, 2013-08-19 21:04:21]

LGTM if you're sure you like the defaulting behavior.

https://codereview.chromium.org/22929006/diff/10001/platform_tools/android/bi...
File platform_tools/android/bin/android_make (right):

https://codereview.chromium.org/22929006/diff/10001/platform_tools/android/bi...
platform_tools/android/bin/android_make:7: # listed in the .android_config
instead of the default device type.
This behavior is still a little strange to me - in my opinion, the logical
fallback chain is: device provided with "-d", previously-used device in
.android_config, arm_v7.  I don't use this workflow often though, so if arm_v7
is the common case I'm all for using that.

[djsollen, 2013-08-20 12:23:05]

Committed patchset #3 manually as r10807 (presubmit successful).