Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: platform_tools/android/bin/android_make

Issue 22929006: default to device type of last build if no device type is given (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: addressing comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « platform_tools/android/bin/android_install_apk ('k') | platform_tools/android/bin/android_setup.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/bin/android_make
diff --git a/platform_tools/android/bin/android_make b/platform_tools/android/bin/android_make
index ad52d67bca62c1aa10abd0ba5cb5b43330813588..10ddd3301bd6e3ba52b8b60bbc9359e1145bfc60 100755
--- a/platform_tools/android/bin/android_make
+++ b/platform_tools/android/bin/android_make
@@ -1,8 +1,21 @@
#!/bin/bash
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+
+# remove the existing .android_config file prior to running android_setup. If
+# we did not remove this here then we would build for whatever device type was
+# listed in the .android_config instead of the default device type.
borenet 2013/08/19 21:04:22 This behavior is still a little strange to me - in
+if [ -f .android_config ]
+then
+ rm .android_config
+fi
+
+# run the config to setup the environment
source $SCRIPT_DIR/android_setup.sh
+# write the device id into the .android_config file
+echo $DEVICE_ID > .android_config
+
for arg in ${APP_ARGS[@]}
do
if [[ "${arg}" == "--use-ccache" ]];
@@ -26,9 +39,6 @@ if [[ -n "$ANDROID_MAKE_CCACHE" ]]; then
fi
fi
-# write the out directory into the .android_config file
-echo $SKIA_OUT > .android_config
-
make ${makeVars[@]}
if [ $? != 0 ]
then
« no previous file with comments | « platform_tools/android/bin/android_install_apk ('k') | platform_tools/android/bin/android_setup.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698