ui/file_manager/gallery/js/compiled_resources.gyp - Issue 2292873003: Divide volume_manager.js into files for each classes and extract interfaces from them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/gallery/js/compiled_resources.gyp

Issue 2292873003: Divide volume_manager.js into files for each classes and extract interfaces from them. (Closed)

Patch Set: Address comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js ('k') | ui/file_manager/video_player/js/compiled_resources.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/gallery/js/compiled_resources.gyp

diff --git a/ui/file_manager/gallery/js/compiled_resources.gyp b/ui/file_manager/gallery/js/compiled_resources.gyp

index 0b528197944597e9241b311abfaec862a36b83ce..7808ba1bb75a24fca17e808cdfa6824f0052fa73 100644

--- a/ui/file_manager/gallery/js/compiled_resources.gyp

+++ b/ui/file_manager/gallery/js/compiled_resources.gyp

@@ -25,7 +25,12 @@

'../../file_manager/common/js/metrics.js',

'../../file_manager/background/js/app_window_wrapper.js',

'../../file_manager/background/js/background_base.js',

- '../../file_manager/background/js/volume_manager.js',

+ '../../file_manager/background/js/entry_location_impl.js',

+ '../../file_manager/background/js/volume_info_impl.js',

+ '../../file_manager/background/js/volume_info_list_impl.js',

+ '../../file_manager/background/js/volume_manager_factory.js',

+ '../../file_manager/background/js/volume_manager_impl.js',

+ '../../file_manager/background/js/volume_manager_util.js',

'externs': [

'<(EXTERNS_DIR)/chrome_extensions.js',

@@ -34,10 +39,13 @@

'<(EXTERNS_DIR)/metrics_private.js',

'../../../../third_party/analytics/externs.js',

'../../externs/chrome_test.js',

+ '../../externs/entry_location.js',

'../../externs/es6_workaround.js',

'../../externs/gallery_background.js',

'../../externs/platform.js',

'../../externs/volume_info.js',

+ '../../externs/volume_info_list.js',

+ '../../externs/volume_manager.js',

'includes': [

@@ -110,7 +118,6 @@

'../../file_manager/foreground/js/ui/files_confirm_dialog.js',

'../../file_manager/foreground/js/ui/share_dialog.js',

'../../file_manager/foreground/js/volume_manager_wrapper.js',

- '../../file_manager/background/js/volume_manager.js',

'../../image_loader/image_loader_client.js',

'./image_editor/image_util.js',

'./image_editor/viewport.js',

@@ -140,7 +147,9 @@

'<(EXTERNS_DIR)/metrics_private.js',

'../../../../third_party/analytics/externs.js',

'../../../../third_party/closure_compiler/externs/polymer-1.0.js',

+ '../../externs/background_window_common.js',

'../../externs/chrome_test.js',

+ '../../externs/entry_location.js',

'../../externs/es6_workaround.js',

'../../externs/exif_entry.js',

'../../externs/files_elements.js',

@@ -148,6 +157,8 @@

'../../externs/paper_elements.js',

'../../externs/platform.js',

'../../externs/volume_info.js',

+ '../../externs/volume_info_list.js',

+ '../../externs/volume_manager.js',

'../../externs/webview_tag.js',