Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: ui/file_manager/gallery/js/compiled_resources.gyp

Issue 2292873003: Divide volume_manager.js into files for each classes and extract interfaces from them. (Closed)
Patch Set: Address comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'targets': [ 5 'targets': [
6 { 6 {
7 'target_name': 'background', 7 'target_name': 'background',
8 'variables': { 8 'variables': {
9 'depends': [ 9 'depends': [
10 '../../../../third_party/jstemplate/compiled_resources.gyp:jstemplate' , 10 '../../../../third_party/jstemplate/compiled_resources.gyp:jstemplate' ,
11 '../../../webui/resources/js/cr.js', 11 '../../../webui/resources/js/cr.js',
12 '../../../webui/resources/js/cr/event_target.js', 12 '../../../webui/resources/js/cr/event_target.js',
13 '../../../webui/resources/js/cr/ui.js', 13 '../../../webui/resources/js/cr/ui.js',
14 '../../../webui/resources/js/cr/ui/array_data_model.js', 14 '../../../webui/resources/js/cr/ui/array_data_model.js',
15 '../../../webui/resources/js/load_time_data.js', 15 '../../../webui/resources/js/load_time_data.js',
16 '../../../webui/resources/js/promise_resolver.js', 16 '../../../webui/resources/js/promise_resolver.js',
17 '../../../webui/resources/js/util.js', 17 '../../../webui/resources/js/util.js',
18 '../../file_manager/common/js/util.js', 18 '../../file_manager/common/js/util.js',
19 '../../file_manager/common/js/async_util.js', 19 '../../file_manager/common/js/async_util.js',
20 '../../file_manager/common/js/volume_manager_common.js', 20 '../../file_manager/common/js/volume_manager_common.js',
21 '../../file_manager/common/js/error_util.js', 21 '../../file_manager/common/js/error_util.js',
22 '../../file_manager/common/js/file_type.js', 22 '../../file_manager/common/js/file_type.js',
23 '../../file_manager/common/js/metrics_base.js', 23 '../../file_manager/common/js/metrics_base.js',
24 '../../file_manager/common/js/metrics_events.js', 24 '../../file_manager/common/js/metrics_events.js',
25 '../../file_manager/common/js/metrics.js', 25 '../../file_manager/common/js/metrics.js',
26 '../../file_manager/background/js/app_window_wrapper.js', 26 '../../file_manager/background/js/app_window_wrapper.js',
27 '../../file_manager/background/js/background_base.js', 27 '../../file_manager/background/js/background_base.js',
28 '../../file_manager/background/js/volume_manager.js', 28 '../../file_manager/background/js/entry_location_impl.js',
29 '../../file_manager/background/js/volume_info_impl.js',
30 '../../file_manager/background/js/volume_info_list_impl.js',
31 '../../file_manager/background/js/volume_manager_factory.js',
32 '../../file_manager/background/js/volume_manager_impl.js',
33 '../../file_manager/background/js/volume_manager_util.js',
29 ], 34 ],
30 'externs': [ 35 'externs': [
31 '<(EXTERNS_DIR)/chrome_extensions.js', 36 '<(EXTERNS_DIR)/chrome_extensions.js',
32 '<(EXTERNS_DIR)/chrome_send.js', 37 '<(EXTERNS_DIR)/chrome_send.js',
33 '<(EXTERNS_DIR)/file_manager_private.js', 38 '<(EXTERNS_DIR)/file_manager_private.js',
34 '<(EXTERNS_DIR)/metrics_private.js', 39 '<(EXTERNS_DIR)/metrics_private.js',
35 '../../../../third_party/analytics/externs.js', 40 '../../../../third_party/analytics/externs.js',
36 '../../externs/chrome_test.js', 41 '../../externs/chrome_test.js',
42 '../../externs/entry_location.js',
37 '../../externs/es6_workaround.js', 43 '../../externs/es6_workaround.js',
38 '../../externs/gallery_background.js', 44 '../../externs/gallery_background.js',
39 '../../externs/platform.js', 45 '../../externs/platform.js',
40 '../../externs/volume_info.js', 46 '../../externs/volume_info.js',
47 '../../externs/volume_info_list.js',
48 '../../externs/volume_manager.js',
41 ], 49 ],
42 }, 50 },
43 'includes': [ 51 'includes': [
44 '../../compile_js.gypi', 52 '../../compile_js.gypi',
45 ], 53 ],
46 }, 54 },
47 { 55 {
48 'target_name': 'gallery', 56 'target_name': 'gallery',
49 'variables': { 57 'variables': {
50 'depends': [ 58 'depends': [
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 '../../file_manager/foreground/js/metadata/metadata_model.js', 111 '../../file_manager/foreground/js/metadata/metadata_model.js',
104 '../../file_manager/foreground/js/metadata/metadata_provider.js', 112 '../../file_manager/foreground/js/metadata/metadata_provider.js',
105 '../../file_manager/foreground/js/metadata/multi_metadata_provider.js' , 113 '../../file_manager/foreground/js/metadata/multi_metadata_provider.js' ,
106 '../../file_manager/foreground/js/metadata/thumbnail_model.js', 114 '../../file_manager/foreground/js/metadata/thumbnail_model.js',
107 '../../file_manager/foreground/js/share_client.js', 115 '../../file_manager/foreground/js/share_client.js',
108 '../../file_manager/foreground/js/thumbnail_loader.js', 116 '../../file_manager/foreground/js/thumbnail_loader.js',
109 '../../file_manager/foreground/js/ui/file_manager_dialog_base.js', 117 '../../file_manager/foreground/js/ui/file_manager_dialog_base.js',
110 '../../file_manager/foreground/js/ui/files_confirm_dialog.js', 118 '../../file_manager/foreground/js/ui/files_confirm_dialog.js',
111 '../../file_manager/foreground/js/ui/share_dialog.js', 119 '../../file_manager/foreground/js/ui/share_dialog.js',
112 '../../file_manager/foreground/js/volume_manager_wrapper.js', 120 '../../file_manager/foreground/js/volume_manager_wrapper.js',
113 '../../file_manager/background/js/volume_manager.js',
114 '../../image_loader/image_loader_client.js', 121 '../../image_loader/image_loader_client.js',
115 './image_editor/image_util.js', 122 './image_editor/image_util.js',
116 './image_editor/viewport.js', 123 './image_editor/viewport.js',
117 './image_editor/image_buffer.js', 124 './image_editor/image_buffer.js',
118 './image_editor/image_view.js', 125 './image_editor/image_view.js',
119 './image_editor/commands.js', 126 './image_editor/commands.js',
120 './image_editor/image_editor.js', 127 './image_editor/image_editor.js',
121 './image_editor/image_transform.js', 128 './image_editor/image_transform.js',
122 './image_editor/image_adjust.js', 129 './image_editor/image_adjust.js',
123 './image_editor/filter.js', 130 './image_editor/filter.js',
124 './image_editor/image_encoder.js', 131 './image_editor/image_encoder.js',
125 './image_editor/exif_encoder.js', 132 './image_editor/exif_encoder.js',
126 './dimmable_ui_controller.js', 133 './dimmable_ui_controller.js',
127 './entry_list_watcher.js', 134 './entry_list_watcher.js',
128 './error_banner.js', 135 './error_banner.js',
129 './gallery_data_model.js', 136 './gallery_data_model.js',
130 './gallery_item.js', 137 './gallery_item.js',
131 './gallery_util.js', 138 './gallery_util.js',
132 './ribbon.js', 139 './ribbon.js',
133 './slide_mode.js', 140 './slide_mode.js',
134 './thumbnail_mode.js', 141 './thumbnail_mode.js',
135 ], 142 ],
136 'externs': [ 143 'externs': [
137 '<(EXTERNS_DIR)/chrome_extensions.js', 144 '<(EXTERNS_DIR)/chrome_extensions.js',
138 '<(EXTERNS_DIR)/chrome_send.js', 145 '<(EXTERNS_DIR)/chrome_send.js',
139 '<(EXTERNS_DIR)/file_manager_private.js', 146 '<(EXTERNS_DIR)/file_manager_private.js',
140 '<(EXTERNS_DIR)/metrics_private.js', 147 '<(EXTERNS_DIR)/metrics_private.js',
141 '../../../../third_party/analytics/externs.js', 148 '../../../../third_party/analytics/externs.js',
142 '../../../../third_party/closure_compiler/externs/polymer-1.0.js', 149 '../../../../third_party/closure_compiler/externs/polymer-1.0.js',
150 '../../externs/background_window_common.js',
143 '../../externs/chrome_test.js', 151 '../../externs/chrome_test.js',
152 '../../externs/entry_location.js',
144 '../../externs/es6_workaround.js', 153 '../../externs/es6_workaround.js',
145 '../../externs/exif_entry.js', 154 '../../externs/exif_entry.js',
146 '../../externs/files_elements.js', 155 '../../externs/files_elements.js',
147 '../../externs/gallery_foreground.js', 156 '../../externs/gallery_foreground.js',
148 '../../externs/paper_elements.js', 157 '../../externs/paper_elements.js',
149 '../../externs/platform.js', 158 '../../externs/platform.js',
150 '../../externs/volume_info.js', 159 '../../externs/volume_info.js',
160 '../../externs/volume_info_list.js',
161 '../../externs/volume_manager.js',
151 '../../externs/webview_tag.js', 162 '../../externs/webview_tag.js',
152 ], 163 ],
153 }, 164 },
154 'includes': [ 165 'includes': [
155 '../../compile_js.gypi', 166 '../../compile_js.gypi',
156 ], 167 ],
157 } 168 }
158 ], 169 ],
159 } 170 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698