Formatter fixes and tweaks.

pkg/analyzer_experimental/lib/src/services/formatter_impl.dart

Index: pkg/analyzer_experimental/lib/src/services/formatter_impl.dart
===================================================================
--- pkg/analyzer_experimental/lib/src/services/formatter_impl.dart	(revision 26430)
+++ pkg/analyzer_experimental/lib/src/services/formatter_impl.dart	(working copy)
@@ -387,7 +387,8 @@
   visitDeclaredIdentifier(DeclaredIdentifier node) {
     token(node.keyword);
     space();
-    visitSuffixed(node.type, ' ');
+    visit(node.type);
+    space();

[Brian Wilkerson, 2013/08/21 18:18:53]

Do you want to mark somehow (comment perhaps) that the space should only be
printed if there is a type? It might be hard to find later on.

[pquitslund, 2013/08/21 19:40:40]

Good catch.  Fixed!

     visit(node.identifier);
   }
 
@@ -461,7 +462,8 @@
   visitFieldFormalParameter(FieldFormalParameter node) {
     token(node.keyword);
     space();
-    visitSuffixed(node.type, ' ');
+    visit(node.type);
+    space();
     token(node.thisToken);
     token(node.period);
     visit(node.identifier);
@@ -477,7 +479,7 @@
     token(node.inKeyword);
     space();
     visit(node.iterator);
-    token(node.leftParenthesis);
+    token(node.rightParenthesis);
     space();
     visit(node.body);
   }
@@ -834,8 +836,7 @@
   }
 
   visitSimpleFormalParameter(SimpleFormalParameter node) {
-    token(node.keyword);
-    space();
+    modifier(node.keyword);
     visitSuffixed(node.type, ' ');
     visit(node.identifier);
   }
@@ -914,7 +915,9 @@
   }
 
   visitTopLevelVariableDeclaration(TopLevelVariableDeclaration node) {
-    visitSuffixed(node.variables, ';');
+    preservePrecedingNewlines = true;
+    visit(node.variables);
+    token(node.semicolon);
   }
 
   visitTryStatement(TryStatement node) {
@@ -950,7 +953,10 @@
 
   visitVariableDeclaration(VariableDeclaration node) {
     visit(node.name);
-    visitPrefixed(' = ', node.initializer);
+    space();

[Brian Wilkerson, 2013/08/21 18:18:53]

Similarly here, the spaces and equals are only wanted (and the equals can be
null) if the initializer is not null.

[pquitslund, 2013/08/21 19:40:40]

Exactly right.  Thanks!

+    token(node.equals);
+    space();
+    visit(node.initializer);
   }
 
   visitVariableDeclarationList(VariableDeclarationList node) {
@@ -963,6 +969,7 @@
   visitVariableDeclarationStatement(VariableDeclarationStatement node) {
     visit(node.variables);
     token(node.semicolon);
+    needsNewline = true;
   }
 
   visitWhileStatement(WhileStatement node) {