Formatter fixes and tweaks.

pkg/analyzer_experimental/lib/src/services/formatter_impl.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library formatter_impl;
 
 import 'dart:math';
 
 import 'package:analyzer_experimental/analyzer.dart';
 import 'package:analyzer_experimental/src/generated/parser.dart';
@@ skipping 369 matching lines @@
 
   visitContinueStatement(ContinueStatement node) {
     token(node.keyword);
     visitPrefixed(' ', node.label);
     token(node.semicolon);
   }
 
   visitDeclaredIdentifier(DeclaredIdentifier node) {
     token(node.keyword);
     space();
-    visitSuffixed(node.type, ' ');
+    visit(node.type);
+    space();

[Brian Wilkerson, 2013/08/21 18:18:53]

Do you want to mark somehow (comment perhaps) that the space should only be
printed if there is a type? It might be hard to find later on.

[pquitslund, 2013/08/21 19:40:40]

Good catch.  Fixed!

     visit(node.identifier);
   }
 
   visitDefaultFormalParameter(DefaultFormalParameter node) {
     visit(node.parameter);
     if (node.separator != null) {
       space();
       token(node.separator);
       visitPrefixed(' ', node.defaultValue);
     }
@@ skipping 53 matching lines @@
   visitFieldDeclaration(FieldDeclaration node) {
     token(node.keyword);
     space();
     visit(node.fields);
     token(node.semicolon);
   }
 
   visitFieldFormalParameter(FieldFormalParameter node) {
     token(node.keyword);
     space();
-    visitSuffixed(node.type, ' ');
+    visit(node.type);
+    space();
     token(node.thisToken);
     token(node.period);
     visit(node.identifier);
     visit(node.parameters);
   }
 
   visitForEachStatement(ForEachStatement node) {
     token(node.forKeyword);
     space();
     token(node.leftParenthesis);
     visit(node.loopVariable);
     space();
     token(node.inKeyword);
     space();
     visit(node.iterator);
-    token(node.leftParenthesis);
+    token(node.rightParenthesis);
     space();
     visit(node.body);
   }
 
   visitFormalParameterList(FormalParameterList node) {
     var groupEnd = null;
     token(node.leftParenthesis);
     var parameters = node.parameters;
     var size = parameters.length;
     for (var i = 0; i < size; i++) {
@@ skipping 336 matching lines @@
     token(node.scriptTag);
   }
 
   visitShowCombinator(ShowCombinator node) {
     token(node.keyword);
     space();
     visitList(node.shownNames, ', ');
   }
 
   visitSimpleFormalParameter(SimpleFormalParameter node) {
-    token(node.keyword);
-    space();
+    modifier(node.keyword);
     visitSuffixed(node.type, ' ');
     visit(node.identifier);
   }
 
   visitSimpleIdentifier(SimpleIdentifier node) {
     token(node.token);
   }
 
   visitSimpleStringLiteral(SimpleStringLiteral node) {
     token(node.literal);
@@ skipping 58 matching lines @@
     token(node.keyword);
   }
 
   visitThrowExpression(ThrowExpression node) {
     token(node.keyword);
     space();
     visit(node.expression);
   }
 
   visitTopLevelVariableDeclaration(TopLevelVariableDeclaration node) {
-    visitSuffixed(node.variables, ';');
+    preservePrecedingNewlines = true;
+    visit(node.variables);
+    token(node.semicolon);
   }
 
   visitTryStatement(TryStatement node) {
     preservePrecedingNewlines = true;
     token(node.tryKeyword);
     space();
     visit(node.body);
     visitPrefixedList(' ', node.catchClauses, ' ');
     visitPrefixed(' finally ', node.finallyClause);
   }
@@ skipping 15 matching lines @@
   }
 
   visitTypeParameterList(TypeParameterList node) {
     token(node.leftBracket);
     visitList(node.typeParameters, ', ');
     token(node.rightBracket);
   }
 
   visitVariableDeclaration(VariableDeclaration node) {
     visit(node.name);
-    visitPrefixed(' = ', node.initializer);
+    space();

[Brian Wilkerson, 2013/08/21 18:18:53]

Similarly here, the spaces and equals are only wanted (and the equals can be
null) if the initializer is not null.

[pquitslund, 2013/08/21 19:40:40]

Exactly right.  Thanks!

+    token(node.equals);
+    space();
+    visit(node.initializer);
   }
 
   visitVariableDeclarationList(VariableDeclarationList node) {
     token(node.keyword);
     space();
     visitSuffixed(node.type, ' ');
     visitList(node.variables, ', ');
   }
 
   visitVariableDeclarationStatement(VariableDeclarationStatement node) {
     visit(node.variables);
     token(node.semicolon);
+    needsNewline = true;
   }
 
   visitWhileStatement(WhileStatement node) {
     token(node.keyword);
     space();
     token(node.leftParenthesis);
     visit(node.condition);
     token(node.rightParenthesis);
     space();
     visit(node.body);
@@ skipping 175 matching lines @@
     var lastLine =
         lineInfo.getLocation(last.offset).lineNumber;
     var currentLine =
         lineInfo.getLocation(current.offset).lineNumber;
     return  currentLine - lastLine;
   }
 
   String toString() => writer.toString();
   
 }