Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2292663002: add gn_android_flavor (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio, borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add gn_android_flavor This ought to support compiles for now. Am I picking up my CIPD ndk packages right? The main thing to note is that I'm passing the target_arch directly through as target_cpu. This means these bots will have a slightly different naming convention than we've been using, but it'll agree with what you must type yourself when using GN to build for Android: - Arm7 -> arm - Arm64 -> arm64 - Mips -> mipsel - Mips64 -> mips64el - x86 -> x86 (unchanged) - x86_64 -> x64 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2292663002 Committed: https://skia.googlesource.com/skia/+/82023d590cd2f9533fe2147997b9f2075a33638a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -35 lines) Patch
M infra/bots/recipe_modules/flavor/api.py View 2 chunks +5 lines, -0 lines 0 comments Download
A infra/bots/recipe_modules/flavor/gn_android_flavor.py View 1 chunk +40 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_compile.py View 3 chunks +4 lines, -2 lines 0 comments Download
A + infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-mipsel-Debug-GN_Android.json View 9 chunks +13 lines, -13 lines 0 comments Download
A + infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-Clang-arm64-Release-GN_Android.json View 7 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mtklein_C
Is there a way I can test this locally, either by treating my desktop as ...
4 years, 3 months ago (2016-08-29 19:26:12 UTC) #4
mtklein_C
On 2016/08/29 at 19:26:12, mtklein_C wrote: > Is there a way I can test this ...
4 years, 3 months ago (2016-08-29 19:34:26 UTC) #5
borenet
On 2016/08/29 19:34:26, mtklein_C wrote: > On 2016/08/29 at 19:26:12, mtklein_C wrote: > > Is ...
4 years, 3 months ago (2016-08-29 19:41:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292663002/1
4 years, 3 months ago (2016-08-29 19:44:09 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 20:14:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/82023d590cd2f9533fe2147997b9f2075a33638a

Powered by Google App Engine
This is Rietveld 408576698