Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: infra/bots/recipe_modules/flavor/api.py

Issue 2292663002: add gn_android_flavor (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | infra/bots/recipe_modules/flavor/gn_android_flavor.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 # pylint: disable=W0201 6 # pylint: disable=W0201
7 7
8 8
9 from recipe_engine import recipe_api 9 from recipe_engine import recipe_api
10 10
11 from . import android_flavor 11 from . import android_flavor
12 from . import cmake_flavor 12 from . import cmake_flavor
13 from . import coverage_flavor 13 from . import coverage_flavor
14 from . import default_flavor 14 from . import default_flavor
15 from . import gn_android_flavor
15 from . import gn_flavor 16 from . import gn_flavor
16 from . import ios_flavor 17 from . import ios_flavor
17 from . import pdfium_flavor 18 from . import pdfium_flavor
18 from . import valgrind_flavor 19 from . import valgrind_flavor
19 from . import xsan_flavor 20 from . import xsan_flavor
20 21
21 22
22 TEST_EXPECTED_SKP_VERSION = '42' 23 TEST_EXPECTED_SKP_VERSION = '42'
23 TEST_EXPECTED_SVG_VERSION = '42' 24 TEST_EXPECTED_SVG_VERSION = '42'
24 TEST_EXPECTED_SK_IMAGE_VERSION = '42' 25 TEST_EXPECTED_SK_IMAGE_VERSION = '42'
(...skipping 30 matching lines...) Expand all
55 56
56 def is_xsan(builder_cfg): 57 def is_xsan(builder_cfg):
57 return ('ASAN' in builder_cfg.get('extra_config', '') or 58 return ('ASAN' in builder_cfg.get('extra_config', '') or
58 'MSAN' in builder_cfg.get('extra_config', '') or 59 'MSAN' in builder_cfg.get('extra_config', '') or
59 'TSAN' in builder_cfg.get('extra_config', '')) 60 'TSAN' in builder_cfg.get('extra_config', ''))
60 61
61 62
62 class SkiaFlavorApi(recipe_api.RecipeApi): 63 class SkiaFlavorApi(recipe_api.RecipeApi):
63 def get_flavor(self, builder_cfg): 64 def get_flavor(self, builder_cfg):
64 """Return a flavor utils object specific to the given builder.""" 65 """Return a flavor utils object specific to the given builder."""
66 gn_android = gn_android_flavor.GNAndroidFlavorUtils(self.m)
67 if gn_android.supported():
68 return gn_android
69
65 gn = gn_flavor.GNFlavorUtils(self.m) 70 gn = gn_flavor.GNFlavorUtils(self.m)
66 if gn.supported(): 71 if gn.supported():
67 return gn 72 return gn
68 73
69 if is_android(builder_cfg): 74 if is_android(builder_cfg):
70 return android_flavor.AndroidFlavorUtils(self.m) 75 return android_flavor.AndroidFlavorUtils(self.m)
71 elif is_cmake(builder_cfg): 76 elif is_cmake(builder_cfg):
72 return cmake_flavor.CMakeFlavorUtils(self.m) 77 return cmake_flavor.CMakeFlavorUtils(self.m)
73 elif is_ios(builder_cfg): 78 elif is_ios(builder_cfg):
74 return ios_flavor.iOSFlavorUtils(self.m) 79 return ios_flavor.iOSFlavorUtils(self.m)
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 version, 235 version,
231 VERSION_FILE_SVG, 236 VERSION_FILE_SVG,
232 self.m.vars.tmp_dir, 237 self.m.vars.tmp_dir,
233 self.m.vars.local_svg_dir, 238 self.m.vars.local_svg_dir,
234 self.device_dirs.svg_dir, 239 self.device_dirs.svg_dir,
235 test_expected_version=self.m.properties.get( 240 test_expected_version=self.m.properties.get(
236 'test_downloaded_svg_version', TEST_EXPECTED_SVG_VERSION), 241 'test_downloaded_svg_version', TEST_EXPECTED_SVG_VERSION),
237 test_actual_version=self.m.properties.get( 242 test_actual_version=self.m.properties.get(
238 'test_downloaded_svg_version', TEST_EXPECTED_SVG_VERSION)) 243 'test_downloaded_svg_version', TEST_EXPECTED_SVG_VERSION))
239 return version 244 return version
OLDNEW
« no previous file with comments | « no previous file | infra/bots/recipe_modules/flavor/gn_android_flavor.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698