Chromium Code Reviews Chromium Code Reviews
Issue 22926033:
Enable password saving for dynamic password forms (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/test/data/password/dynamic_password_form.html |
| diff --git a/chrome/test/data/password/dynamic_password_form.html b/chrome/test/data/password/dynamic_password_form.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..f314b446e3ce7074be6971e6b0e7999ec30c7835 |
| --- /dev/null |
| +++ b/chrome/test/data/password/dynamic_password_form.html |
| @@ -0,0 +1,32 @@ |
| +<html> |
| +<head> |
| +<script> |
| +function createDynamicForm() { |
| + var dynamicForm = document.createElement('form'); |
| + dynamicForm.setAttribute('name', 'dynamic_form'); |
| + dynamicForm.setAttribute('method','post'); |
| + dynamicForm.setAttribute('action','done.html'); |
|
Ilya Sherman
2013/09/10 01:27:58
nit: Please leave a space after the comma (lines 7
guohui
2013/09/13 15:09:39
Done.
|
| + dynamicForm.setAttribute('onsubmit', 'return true;'); |
| + |
| + var inputUsername = document.createElement('input'); |
| + inputUsername.setAttribute('type','text'); |
| + inputUsername.setAttribute('name','username'); |
|
Ilya Sherman
2013/09/10 01:27:58
Ditto here and below.
guohui
2013/09/13 15:09:39
Done.
|
| + |
| + var inputPassword = document.createElement('input'); |
| + inputPassword.setAttribute('type','password'); |
| + inputPassword.setAttribute('name','password'); |
| + |
| + var submitButton = document.createElement('input'); |
| + submitButton.setAttribute('type','submit'); |
| + submitButton.setAttribute('value','Submit'); |
| + |
| + dynamicForm.appendChild(inputUsername); |
| + dynamicForm.appendChild(inputPassword); |
| + dynamicForm.appendChild(submitButton); |
| + |
| + document.body.appendChild(dynamicForm); |
| +} |
| +</script> |
| +</head> |
| +<body onload='createDynamicForm()'></body> |
|
Garrett Casto
2013/09/10 17:13:45
We discussed this offline, but just as a reminder:
guohui
2013/09/13 15:09:39
As discussed offline, this does test the new code
|
| +</html> |
