chrome/test/data/password/dynamic_password_form.html - Issue 22926033: Enable password saving for dynamic password forms

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/password/dynamic_password_form.html

Issue 22926033: Enable password saving for dynamic password forms (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test added Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | components/autofill/content/renderer/autofill_agent.h » ('j') | components/autofill/content/renderer/autofill_agent.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script>

	4 function createDynamicForm() {

	5 var dynamicForm = document.createElement('form');

	6 dynamicForm.setAttribute('name', 'dynamic_form');

	7 dynamicForm.setAttribute('method','post');

	8 dynamicForm.setAttribute('action','done.html');
	Ilya Sherman 2013/09/10 01:27:58 nit: Please leave a space after the comma (lines 7 nit: Please leave a space after the comma (lines 7 and 8). guohui 2013/09/13 15:09:39 Done. Show quoted text On 2013/09/10 01:27:58, Ilya Sherman wrote: > nit: Please leave a space after the comma (lines 7 and 8). Done.
	9 dynamicForm.setAttribute('onsubmit', 'return true;');

	10

	11 var inputUsername = document.createElement('input');

	12 inputUsername.setAttribute('type','text');

	13 inputUsername.setAttribute('name','username');
	Ilya Sherman 2013/09/10 01:27:58 Ditto here and below. Ditto here and below. guohui 2013/09/13 15:09:39 Done. Show quoted text On 2013/09/10 01:27:58, Ilya Sherman wrote: > Ditto here and below. Done.
	14

	15 var inputPassword = document.createElement('input');

	16 inputPassword.setAttribute('type','password');

	17 inputPassword.setAttribute('name','password');

	18

	19 var submitButton = document.createElement('input');

	20 submitButton.setAttribute('type','submit');

	21 submitButton.setAttribute('value','Submit');

	22

	23 dynamicForm.appendChild(inputUsername);

	24 dynamicForm.appendChild(inputPassword);

	25 dynamicForm.appendChild(submitButton);

	26

	27 document.body.appendChild(dynamicForm);

	28 }

	29 </script>

	30 </head>

	31 <body onload='createDynamicForm()'></body>
	Garrett Casto 2013/09/10 17:13:45 We discussed this offline, but just as a reminder: We discussed this offline, but just as a reminder: Could you check and make sure that this is actually testing the new code path? I think that DidFinishLoad may be called after onload(), which means we would have caught this anyway. You may need to move the 'createDynamicForm()' call to the test itself. guohui 2013/09/13 15:09:39 As discussed offline, this does test the new code Show quoted text On 2013/09/10 17:13:45, Garrett Casto wrote: > We discussed this offline, but just as a reminder: > > Could you check and make sure that this is actually testing the new code path? I > think that DidFinishLoad may be called after onload(), which means we would have > caught this anyway. You may need to move the 'createDynamicForm()' call to the > test itself. As discussed offline, this does test the new code path. Though DidFinishLoad is called after onLoad, it does not add new forms to PasswordManager, its sole purpose is to show password save info bar if a managed form is just submitted, so without this CL, the test would have failed. However, I agree this test could be confusing, and it is not the best example for JS generated form, so i updated the test to trigger form creation upon simulated button click.
	32 </html>

OLD	NEW