Add --trace-hydrogen-filter flag.

Add --trace-hydrogen-filter flag.

The flag restricts hydrogen.cfg output to functions passing the filter,
similar to what --hydrogen-filter does for optimization in general.

This is useful for investigating large repro cases where tracing all
functions would lead to an impractically large hydrogen.cfg file, but
restricting optimization using --hydrogen-filter is undesirable
(e.g. because it might cause the issue to no longer reproduce).

R=mstarzinger@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=16302

[Jakob Kummerow, 2013-08-23 10:38:27]

PTAL.

[Michael Starzinger, 2013-08-23 11:18:13]

https://codereview.chromium.org/22926025/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/22926025/diff/1/src/objects.h#newcode8310
src/objects.h:8310: bool PassesFilter(const char* raw_filter);
IMHO this should be a method on JSFunction instead of on String.

[Jakob Kummerow, 2013-08-23 13:19:23]

https://codereview.chromium.org/22926025/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/22926025/diff/1/src/objects.h#newcode8310
src/objects.h:8310: bool PassesFilter(const char* raw_filter);
On 2013/08/23 11:18:13, Michael Starzinger wrote:
> IMHO this should be a method on JSFunction instead of on String.

Sounds reasonable. Done.

[Michael Starzinger, 2013-08-23 13:22:52]

LGTM.

[Jakob Kummerow, 2013-08-23 13:30:13]

Committed patchset #2 manually as r16302 (presubmit successful).

[Michael Starzinger, 2013-08-26 18:00:00]

https://codereview.chromium.org/22926025/diff/6001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/22926025/diff/6001/src/compiler.cc#newcode1264
src/compiler.cc:1264:
info()->closure()->PassesFilter(FLAG_trace_hydrogen_filter));
This breaks --trace-hydrogen in debug mode with --enable-slow-asserts ...

#
# Fatal error in ../src/handles-inl.h, line 69
# CHECK(!FLAG_enable_slow_asserts ||
(IsDereferenceAllowed(INCLUDE_DEFERRED_CHECK))) failed
#

#14 0x083c5d16 in v8::internal::CompilationPhase::ShouldProduceTraceOutput
(this=0xffffca24) at ../src/compiler.cc:1268
#15 0x084db967 in v8::internal::HPhase::~HPhase (this=0xffffca24,
__in_chrg=<optimized out>) at ../src/hydrogen.cc:9849
#16 0x084bb15d in v8::internal::HGraph::AssignDominators (this=0x8abecc0) at
../src/hydrogen.cc:2448
#17 0x084bcd76 in v8::internal::HGraph::Optimize (this=0x8abecc0,
bailout_reason=0xffffcadc) at ../src/hydrogen.cc:2920
#18 0x083c26f2 in v8::internal::OptimizingCompiler::OptimizeGraph
(this=0xffffcb00) at ../src/compiler.cc:463
#19 0x083c1c80 in v8::internal::MakeCrankshaftCode (info=0xffffcc24) at
../src/compiler.cc:303