Add --trace-hydrogen-filter flag.

src/compiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 344 matching lines @@
   }
 
   const int locals_limit = LUnallocated::kMaxFixedSlotIndex;
   if (!info()->osr_ast_id().IsNone() &&
       scope->num_parameters() + 1 + scope->num_stack_slots() > locals_limit) {
     info()->set_bailout_reason(kTooManyParametersLocals);
     return AbortOptimization();
   }
 
   // Take --hydrogen-filter into account.
-  if (!info()->closure()->PassesHydrogenFilter()) {
+  if (!info()->closure()->PassesFilter(FLAG_hydrogen_filter)) {
     info()->AbortOptimization();
     return SetLastStatus(BAILED_OUT);
   }
 
   // Recompile the unoptimized version of the code if the current version
   // doesn't have deoptimization support. Alternatively, we may decide to
   // run the full code generator to get a baseline for the compile-time
   // performance of the hydrogen-based compiler.
   bool should_recompile = !info()->shared_info()->has_deoptimization_support();
   if (should_recompile || FLAG_hydrogen_stats) {
@@ skipping 875 matching lines @@
     size += info_->zone()->allocation_size() - info_zone_start_allocation_size_;
     int64_t ticks = OS::Ticks() - start_ticks_;
     isolate()->GetHStatistics()->SaveTiming(name_, ticks, size);
   }
 }
 
 
 bool CompilationPhase::ShouldProduceTraceOutput() const {
   // Trace if the appropriate trace flag is set and the phase name's first
   // character is in the FLAG_trace_phase command line parameter.
-  bool tracing_on = info()->IsStub() ?
-      FLAG_trace_hydrogen_stubs :
-      FLAG_trace_hydrogen;
+  bool tracing_on = info()->IsStub()
+      ? FLAG_trace_hydrogen_stubs
+      : (FLAG_trace_hydrogen &&
+         info()->closure()->PassesFilter(FLAG_trace_hydrogen_filter));

[Michael Starzinger, 2013/08/26 18:00:00]

This breaks --trace-hydrogen in debug mode with --enable-slow-asserts ...

#
# Fatal error in ../src/handles-inl.h, line 69
# CHECK(!FLAG_enable_slow_asserts ||
(IsDereferenceAllowed(INCLUDE_DEFERRED_CHECK))) failed
#

#14 0x083c5d16 in v8::internal::CompilationPhase::ShouldProduceTraceOutput
(this=0xffffca24) at ../src/compiler.cc:1268
#15 0x084db967 in v8::internal::HPhase::~HPhase (this=0xffffca24,
__in_chrg=<optimized out>) at ../src/hydrogen.cc:9849
#16 0x084bb15d in v8::internal::HGraph::AssignDominators (this=0x8abecc0) at
../src/hydrogen.cc:2448
#17 0x084bcd76 in v8::internal::HGraph::Optimize (this=0x8abecc0,
bailout_reason=0xffffcadc) at ../src/hydrogen.cc:2920
#18 0x083c26f2 in v8::internal::OptimizingCompiler::OptimizeGraph
(this=0xffffcb00) at ../src/compiler.cc:463
#19 0x083c1c80 in v8::internal::MakeCrankshaftCode (info=0xffffcc24) at
../src/compiler.cc:303

   return (tracing_on &&
       OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL);
 }
 
 } }  // namespace v8::internal