Refactor fx_font part 4

Move CFX_SubstFont and CTTFontDesc into their own files

Committed: https://pdfium.googlesource.com/pdfium/+/81ee14da357bb8bb141930d96e07a46f6d472720

[npm, 2016-08-29 15:42:43]

Description was changed from

==========
Refactor fx_font part 4
==========

to

==========
Move CFX_SubstFont and CTTFontDesc into their own files
==========

[npm, 2016-08-29 15:42:43]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, weili@chromium.org

[npm, 2016-08-29 15:54:02]

PTAL

[dsinclair, 2016-08-29 15:58:32]

https://codereview.chromium.org/2292503002/diff/20001/core/fxge/ge/cfx_substf...
File core/fxge/ge/cfx_substfont.cpp (right):

https://codereview.chromium.org/2292503002/diff/20001/core/fxge/ge/cfx_substf...
core/fxge/ge/cfx_substfont.cpp:12: m_Charset = FXFONT_ANSI_CHARSET;
Can these be moved to an initializer list?

CFX_SubstFont::CFX_SubstFont() : m_Charset(FXFONT_ANSI_CHARSEt), ... ?

https://codereview.chromium.org/2292503002/diff/20001/core/fxge/ge/cttfontdesc.h
File core/fxge/ge/cttfontdesc.h (right):

https://codereview.chromium.org/2292503002/diff/20001/core/fxge/ge/cttfontdes...
core/fxge/ge/cttfontdesc.h:24: m_Type = 0;
Initializer list?

https://codereview.chromium.org/2292503002/diff/20001/core/fxge/ge/cttfontdes...
core/fxge/ge/cttfontdesc.h:34: int m_Type;
nit: add blank line between methods and members.

[npm, 2016-08-29 16:08:26]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 16:08:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-08-29 16:19:07]

PTAL

https://codereview.chromium.org/2292503002/diff/20001/core/fxge/ge/cfx_substf...
File core/fxge/ge/cfx_substfont.cpp (right):

https://codereview.chromium.org/2292503002/diff/20001/core/fxge/ge/cfx_substf...
core/fxge/ge/cfx_substfont.cpp:12: m_Charset = FXFONT_ANSI_CHARSET;
On 2016/08/29 15:58:31, dsinclair wrote:
> Can these be moved to an initializer list?
> 
> CFX_SubstFont::CFX_SubstFont() : m_Charset(FXFONT_ANSI_CHARSEt), ... ?

Done.

https://codereview.chromium.org/2292503002/diff/20001/core/fxge/ge/cttfontdesc.h
File core/fxge/ge/cttfontdesc.h (right):

https://codereview.chromium.org/2292503002/diff/20001/core/fxge/ge/cttfontdes...
core/fxge/ge/cttfontdesc.h:24: m_Type = 0;
On 2016/08/29 15:58:31, dsinclair wrote:
> Initializer list?

Done.

https://codereview.chromium.org/2292503002/diff/20001/core/fxge/ge/cttfontdes...
core/fxge/ge/cttfontdesc.h:34: int m_Type;
On 2016/08/29 15:58:31, dsinclair wrote:
> nit: add blank line between methods and members.

Done.

[commit-bot: I haz the power, 2016-08-29 16:22:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 16:22:47]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-08-29 16:34:43]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-08-29 16:34:44]

lgtm

[commit-bot: I haz the power, 2016-08-29 16:34:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 16:36:20]

Description was changed from

==========
Move CFX_SubstFont and CTTFontDesc into their own files
==========

to

==========
Move CFX_SubstFont and CTTFontDesc into their own files

Committed:
https://pdfium.googlesource.com/pdfium/+/81ee14da357bb8bb141930d96e07a46f6d47...
==========

[commit-bot: I haz the power, 2016-08-29 16:36:23]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/81ee14da357bb8bb141930d96e07a46f6d47...