core/fxge/ge/cfx_substfont.cpp - Issue 2292503002: Refactor fx_font part 4

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/fxge/ge/cfx_substfont.cpp

Issue 2292503002: Refactor fx_font part 4 (Closed)

Patch Set: More changes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 PDFium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

	6

	7 #include "core/fxge/include/cfx_substfont.h"

	8

	9 #include "core/fxge/include/fx_font.h"

	10

	11 CFX_SubstFont::CFX_SubstFont() {

	12 m_Charset = FXFONT_ANSI_CHARSET;
	dsinclair 2016/08/29 15:58:31 Can these be moved to an initializer list? CFX_Su Can these be moved to an initializer list? CFX_SubstFont::CFX_SubstFont() : m_Charset(FXFONT_ANSI_CHARSEt), ... ? npm 2016/08/29 16:19:06 Done. Show quoted text On 2016/08/29 15:58:31, dsinclair wrote: > Can these be moved to an initializer list? > > CFX_SubstFont::CFX_SubstFont() : m_Charset(FXFONT_ANSI_CHARSEt), ... ? Done.
	13 m_SubstFlags = 0;

	14 m_Weight = 0;

	15 m_ItalicAngle = 0;

	16 m_bSubstCJK = false;

	17 m_WeightCJK = 0;

	18 m_bItalicCJK = false;

	19 }

OLD	NEW