Add support to resolve unprefixed CSS animations properties.

Add support to resolve unprefixed CSS animations properties.

This is the start of various patches to support unprefixed CSS Animations.
The approach here is the same used for the CSS Transitions :
- Both sets of properties are added to the StylePropertySet which keep them
in sync.
- Only the prefixed ones are resolved.

Added a parsing tests to cover the parsing behavior in detail.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156034

[eseidel, 2013-08-13 17:49:15]

lgtm

OK.

https://codereview.chromium.org/22925002/diff/11001/Source/core/css/CSSParser...
File Source/core/css/CSSParser-in.cpp (right):

https://codereview.chromium.org/22925002/diff/11001/Source/core/css/CSSParser...
Source/core/css/CSSParser-in.cpp:4488: case CSSPropertyAnimationFillMode:
Are the expected implementations of these really identical? :)

https://codereview.chromium.org/22925002/diff/11001/Source/core/css/CSSProper...
File Source/core/css/CSSProperty.h (right):

https://codereview.chromium.org/22925002/diff/11001/Source/core/css/CSSProper...
Source/core/css/CSSProperty.h:113: case CSSPropertyAnimationIterationCount:
Bleh.  This should just be one big static array mapping these.

https://codereview.chromium.org/22925002/diff/11001/Source/core/css/StyleProp...
File Source/core/css/StylePropertyShorthandCustom.cpp (right):

https://codereview.chromium.org/22925002/diff/11001/Source/core/css/StyleProp...
Source/core/css/StylePropertyShorthandCustom.cpp:88: const
StylePropertyShorthand& parsingShorthandForProperty(CSSPropertyID propertyID)
I'm confused by this new wrapper around shorthandForProperty?  I see, we're just
trying to support these as parse-only?

https://codereview.chromium.org/22925002/diff/11001/Source/core/page/UseCount...
File Source/core/page/UseCounter.cpp (right):

https://codereview.chromium.org/22925002/diff/11001/Source/core/page/UseCount...
Source/core/page/UseCounter.cpp:496: case CSSPropertyAnimationTimingFunction:
return 432;
This isn't error prone at all. :p

[commit-bot: I haz the power, 2013-08-13 17:49:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexis.menard@intel.com/22925002/11001

[commit-bot: I haz the power, 2013-08-13 17:54:10]

Change committed as 156034

[darktears, 2013-08-13 18:08:53]

https://codereview.chromium.org/22925002/diff/11001/Source/core/css/CSSParser...
File Source/core/css/CSSParser-in.cpp (right):

https://codereview.chromium.org/22925002/diff/11001/Source/core/css/CSSParser...
Source/core/css/CSSParser-in.cpp:4488: case CSSPropertyAnimationFillMode:
On 2013/08/13 17:49:15, eseidel wrote:
> Are the expected implementations of these really identical? :)

The parsing should be the same. And the tests added proves it. I wrote the new
tests reading the spec and the expected parsing results. This patch does not
cover the actual behaviour on the screen. I will review that later based on the
spec, the existing tests and the bugs open.

https://codereview.chromium.org/22925002/diff/11001/Source/core/css/CSSProper...
File Source/core/css/CSSProperty.h (right):

https://codereview.chromium.org/22925002/diff/11001/Source/core/css/CSSProper...
Source/core/css/CSSProperty.h:113: case CSSPropertyAnimationIterationCount:
On 2013/08/13 17:49:15, eseidel wrote:
> Bleh.  This should just be one big static array mapping these.

Yes, let's fix that in a following patch.

https://codereview.chromium.org/22925002/diff/11001/Source/core/css/StyleProp...
File Source/core/css/StylePropertyShorthandCustom.cpp (right):

https://codereview.chromium.org/22925002/diff/11001/Source/core/css/StyleProp...
Source/core/css/StylePropertyShorthandCustom.cpp:88: const
StylePropertyShorthand& parsingShorthandForProperty(CSSPropertyID propertyID)
On 2013/08/13 17:49:15, eseidel wrote:
> I'm confused by this new wrapper around shorthandForProperty?  I see, we're
just
> trying to support these as parse-only?

No. When we parse the shorthand properties we start matching them following the
order of declaration as in the spec (e.g. border-top then border-right then
border-bottom then border-left) but in few cases this order is different (or you
want to enforce it) when parsing (note that the array generated in
StylePropertyShorthand template is used also to construct the CSSOM and
cssText() values). Concrete example in the case of the animation is that you
want to try parse the animation name last as you still want to match the
keywords first (animation-name can be anything per the spec). I hope I made it
clear. This function only use the set of longhands in a different order for
parsing purpose.

https://codereview.chromium.org/22925002/diff/11001/Source/core/page/UseCount...
File Source/core/page/UseCounter.cpp (right):

https://codereview.chromium.org/22925002/diff/11001/Source/core/page/UseCount...
Source/core/page/UseCounter.cpp:496: case CSSPropertyAnimationTimingFunction:
return 432;
On 2013/08/13 17:49:15, eseidel wrote:
> This isn't error prone at all. :p

:D