Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5252)

Unified Diff: blimp/client/app/android/ime_helper_dialog.h

Issue 2292343002: Hooking up Blimp IME with BlimpContents (Closed)
Patch Set: Addressed initial comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/app/android/ime_helper_dialog.h
diff --git a/blimp/client/app/android/ime_helper_dialog.h b/blimp/client/app/android/ime_helper_dialog.h
index ce419b928d782b954c350008abc7e5c0e201a16f..1d39826e9123c2d9d164d864c767fcf12f100e6e 100644
--- a/blimp/client/app/android/ime_helper_dialog.h
+++ b/blimp/client/app/android/ime_helper_dialog.h
@@ -14,6 +14,7 @@
namespace blimp {
namespace client {
+namespace app {
// The native component of org.chromium.blimp.input.ImeHelperDialog.
class ImeHelperDialog : public ImeFeature::Delegate {
@@ -27,7 +28,8 @@ class ImeHelperDialog : public ImeFeature::Delegate {
// Brings up IME for user to enter text.
void OnShowImeRequested(ui::TextInputType input_type,
- const std::string& text) override;
+ const std::string& text,
+ const ImeFeature::ShowImeCallback& callback) override;
// Hides IME.
void OnHideImeRequested() override;
@@ -50,9 +52,14 @@ class ImeHelperDialog : public ImeFeature::Delegate {
// outgoing and incoming BlimpMessage::IME messages from the engine.
ImeFeature* ime_feature_;
+ // A callback for the current request to be executed on text submission from
+ // the user.
+ ImeFeature::ShowImeCallback text_submit_callback_;
+
DISALLOW_COPY_AND_ASSIGN(ImeHelperDialog);
};
+} // namespace app
} // namespace client
} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698