blimp/client/app/android/blimp_app_jni_registrar.cc - Issue 2292343002: Hooking up Blimp IME with BlimpContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/app/android/blimp_app_jni_registrar.cc

Issue 2292343002: Hooking up Blimp IME with BlimpContents (Closed)

Patch Set: Addressed initial comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/app/android/blimp_app_jni_registrar.cc

diff --git a/blimp/client/app/android/blimp_app_jni_registrar.cc b/blimp/client/app/android/blimp_app_jni_registrar.cc

index 9136adda048c63d1b3096bc9407941633b23e9a5..ee6331422d4258dfd767d3c30cc11cd0f738e3b1 100644

--- a/blimp/client/app/android/blimp_app_jni_registrar.cc

+++ b/blimp/client/app/android/blimp_app_jni_registrar.cc

@@ -21,7 +21,7 @@ base::android::RegistrationMethod kBlimpRegistrationMethods[] = {

{"BlimpClientSessionAndroid", BlimpClientSessionAndroid::RegisterJni},

{"BlimpLibraryLoader", RegisterBlimpLibraryLoaderJni},

{"BlimpView", BlimpView::RegisterJni},

- {"ImeHelperDialog", ImeHelperDialog::RegisterJni},

+ {"ImeHelperDialog", app::ImeHelperDialog::RegisterJni},

{"SafeJson", safe_json::android::RegisterSafeJsonJni},

{"TabControlFeatureAndroid", TabControlFeatureAndroid::RegisterJni},

{"Toolbar", Toolbar::RegisterJni},