Hooking up Blimp IME with BlimpContents

blimp/client/core/contents/blimp_contents_impl.h

Index: blimp/client/core/contents/blimp_contents_impl.h
diff --git a/blimp/client/core/contents/blimp_contents_impl.h b/blimp/client/core/contents/blimp_contents_impl.h
index ac1a2b6db85afeed62dc1a741e3078435c8bf066..b47d11e34500cf6a070f022099573f53ad643857 100644
--- a/blimp/client/core/contents/blimp_contents_impl.h
+++ b/blimp/client/core/contents/blimp_contents_impl.h
@@ -63,6 +63,7 @@ class BlimpContentsImpl : public BlimpContents,
   void SetSizeAndScale(const gfx::Size& size, float device_pixel_ratio);
 
   int id() { return id_; }
+  ImeFeature* GetImeFeature() { return ime_feature_; }

[David Trainor- moved to gerrit, 2016/08/31 05:59:10]

Not used?

[shaktisahu, 2016/08/31 17:28:21]

Done.

 
  private:
   // Handles the back/forward list and loading URLs.
@@ -75,6 +76,9 @@ class BlimpContentsImpl : public BlimpContents,
   // BlimpContentsManager to control the life time of the its observer.
   int id_;
 
+  // Handles the text input for web forms.
+  ImeFeature* ime_feature_;

[David Trainor- moved to gerrit, 2016/08/31 05:59:10]

Should we just pass this right into the BlimpContentsView?

[shaktisahu, 2016/08/31 17:28:21]

In that case, we have to pass ImeFeature to BlimpContentsView::Create() and the
BlimpContentsView constructor.
BlimpContentsView would then have to hold the ime_feature_ as a member in order
to reset the delegate upon destruction. 

[David Trainor- moved to gerrit, 2016/08/31 18:59:54]

That's fine with me.  The ime feature feels like a view-specific thing anyway
:).

+
   // The tab control feature through which the BlimpContentsImpl is able to
   // set size and scale.
   // TODO(mlliu): in the long term, we want to put size and scale in a different