Hooking up Blimp IME with BlimpContents

blimp/client/core/contents/blimp_contents_impl.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_CLIENT_CORE_CONTENTS_BLIMP_CONTENTS_IMPL_H_
 #define BLIMP_CLIENT_CORE_CONTENTS_BLIMP_CONTENTS_IMPL_H_
 
 #include "base/macros.h"
 #include "base/observer_list.h"
 #include "blimp/client/core/contents/blimp_navigation_controller_delegate.h"
@@ skipping 45 matching lines @@
   bool HasObserver(BlimpContentsObserver* observer);
 
   // BlimpNavigationControllerDelegate implementation.
   void OnNavigationStateChanged() override;
 
   // Pushes the size and scale information to the engine, which will affect the
   // web content display area for all tabs.
   void SetSizeAndScale(const gfx::Size& size, float device_pixel_ratio);
 
   int id() { return id_; }
+  ImeFeature* GetImeFeature() { return ime_feature_; }

[David Trainor- moved to gerrit, 2016/08/31 05:59:10]

Not used?

[shaktisahu, 2016/08/31 17:28:21]

Done.

 
  private:
   // Handles the back/forward list and loading URLs.
   BlimpNavigationControllerImpl navigation_controller_;
 
   // A list of all the observers of this BlimpContentsImpl.
   base::ObserverList<BlimpContentsObserver> observers_;
 
   // The id is assigned during contents creation. It is used by
   // BlimpContentsManager to control the life time of the its observer.
   int id_;
 
+  // Handles the text input for web forms.
+  ImeFeature* ime_feature_;

[David Trainor- moved to gerrit, 2016/08/31 05:59:10]

Should we just pass this right into the BlimpContentsView?

[shaktisahu, 2016/08/31 17:28:21]

In that case, we have to pass ImeFeature to BlimpContentsView::Create() and the
BlimpContentsView constructor.
BlimpContentsView would then have to hold the ime_feature_ as a member in order
to reset the delegate upon destruction. 

[David Trainor- moved to gerrit, 2016/08/31 18:59:54]

That's fine with me.  The ime feature feels like a view-specific thing anyway
:).

+
   // The tab control feature through which the BlimpContentsImpl is able to
   // set size and scale.
   // TODO(mlliu): in the long term, we want to put size and scale in a different
   // feature instead of tab control feature. crbug.com/639154.
   TabControlFeature* tab_control_feature_ = nullptr;
 
   // The BlimpContentsView abstracts the platform specific view system details
   // from the BlimpContents.
   std::unique_ptr<BlimpContentsView> blimp_contents_view_;
 
   DISALLOW_COPY_AND_ASSIGN(BlimpContentsImpl);
 };
 
 }  // namespace client
 }  // namespace blimp
 
 #endif  // BLIMP_CLIENT_CORE_CONTENTS_BLIMP_CONTENTS_IMPL_H_